From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Kirch Subject: Re: [PATCH][RFC] use completions instead of sleep_on for rpciod Date: Mon, 9 Feb 2004 11:28:01 +0100 Sender: nfs-admin@lists.sourceforge.net Message-ID: <20040209102801.GC21364@suse.de> References: <20040207144405.GA19416@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: netdev@oss.sgi.com, nfs@lists.sourceforge.net Return-path: To: Christoph Hellwig Content-Disposition: inline In-Reply-To: <20040207144405.GA19416@lst.de> Errors-To: nfs-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org On Sat, Feb 07, 2004 at 03:44:05PM +0100, Christoph Hellwig wrote: > The rpciod shutdown code gives ugly sleep_on without BKL warnings in > -mm. And it looks indeed somewhat racy. Yes, this code is indeed one of the areas that breaks when you use the sunrpc code without the BKL. Another one was the missing spinlock in xprt_alloc_xid. The code in fs/nfs/unlink.c is probably also racy without BKL. So if you remove the sunrpc BKL be prepared for lots and lots of bug reports :) Olaf -- Olaf Kirch | Stop wasting entropy - start using predictable okir@suse.de | tempfile names today! ---------------+ ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs