From: "David S. Miller" <davem@redhat.com>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org,
scott.feldman@intel.com
Subject: Re: 2.6.2 crash after network link failure
Date: Mon, 9 Feb 2004 14:28:42 -0800 [thread overview]
Message-ID: <20040209142842.508ee3b7.davem@redhat.com> (raw)
In-Reply-To: <20040209130134.GA14136@vana.vc.cvut.cz>
On Mon, 9 Feb 2004 14:01:34 +0100
Petr Vandrovec <vandrove@vc.cvut.cz> wrote:
> It looks to me like that we've got skb on completion_queue which was connected
> to a bit unhappy socket - one which had sk->sk_sleep uninitialized. Only problem
> is that only af_unix sets skb->destructor to sock_wfree, so I somehow miss how
> this could be triggered by e100 link change.
It is not only af_unix, any time we invoke skb_set_owner_w() we get sock_wfree()
as the destructor, furthermore sock_def_write_space is the default such handler
given to all sockets unless they override that.
Maybe e100 is mangling it's TX queue or in fact freeing things twice.
I think what might be happening is that somehow the TX queue is corrupted if
e100_config() runs (due to link UP state change) while there are active normal
SKB packets on the TX queue. Or perhaps some TX queue handling locking issue.
Scott, any ideas?
next prev parent reply other threads:[~2004-02-09 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-09 13:01 2.6.2 crash after network link failure Petr Vandrovec
2004-02-09 22:28 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-02-09 23:37 Feldman, Scott
2004-02-10 14:11 ` Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040209142842.508ee3b7.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).