From: "David S. Miller" <davem@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: netdev@oss.sgi.com, kuznet@ms2.inr.ac.ru
Subject: Re: Change proxy_arp to respond only for valid neighbours
Date: Mon, 9 Feb 2004 14:45:57 -0800 [thread overview]
Message-ID: <20040209144557.64f288fe.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0402100033050.1251@u.domain.uli>
On Tue, 10 Feb 2004 00:42:47 +0200 (EET)
Julian Anastasov <ja@ssi.bg> wrote:
> I'm ready to leave this idea if the changes become too complex.
I think it's not so much your changes as this huge ugly ARP receive
processing function. It is a mockery of functional programming :-)
I even tried to split this damn thing up today into smaller chunks but
there is so much shared state (like 6 or 7 live variables that all of
the logic ends up referencing) that such efforts proved futile.
It's hard and time consuming to verify any patch to this code for
that reason.
next prev parent reply other threads:[~2004-02-09 22:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-08 20:44 Change proxy_arp to respond only for valid neighbours Julian Anastasov
2004-02-08 21:14 ` David S. Miller
2004-02-08 21:38 ` Julian Anastasov
2004-02-08 22:44 ` Julian Anastasov
2004-02-09 6:08 ` Pekka Savola
2004-02-09 11:30 ` Julian Anastasov
2004-02-09 15:01 ` jamal
2004-02-09 22:23 ` Julian Anastasov
2004-02-09 22:50 ` jamal
2004-02-09 23:52 ` Julian Anastasov
2004-02-10 1:21 ` jamal
2004-02-10 9:44 ` Julian Anastasov
2004-02-10 10:48 ` jamal
2004-02-11 1:52 ` Julian Anastasov
2004-02-11 13:11 ` jamal
2004-02-11 14:32 ` Julian Anastasov
2004-02-12 4:48 ` jamal
2004-02-12 9:46 ` Julian Anastasov
2004-02-12 14:21 ` jamal
2004-02-12 19:37 ` kuznet
2004-02-13 0:34 ` Julian Anastasov
2004-02-11 13:40 ` jamal
2004-02-11 14:53 ` Julian Anastasov
2004-02-09 20:19 ` David S. Miller
2004-02-09 21:26 ` James Morris
2004-02-09 21:39 ` Ben Greear
2004-02-09 21:45 ` David S. Miller
2004-02-09 22:42 ` Julian Anastasov
2004-02-09 22:45 ` David S. Miller [this message]
2004-02-09 22:32 ` Julian Anastasov
2004-02-09 21:58 ` David S. Miller
2004-02-09 22:49 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040209144557.64f288fe.davem@redhat.com \
--to=davem@redhat.com \
--cc=ja@ssi.bg \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).