From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: davem@redhat.com
Cc: netdev@oss.sgi.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] IPV4: spelling correction
Date: Wed, 11 Feb 2004 04:03:40 +0900 (JST) [thread overview]
Message-ID: <20040211.040340.87331331.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20040210105124.61431b9b.davem@redhat.com>
In article <20040210105124.61431b9b.davem@redhat.com> (at Tue, 10 Feb 2004 10:51:24 -0800), "David S. Miller" <davem@redhat.com> says:
> On Tue, 10 Feb 2004 10:44:48 -0800
> Nivedita Singhvi <niv@us.ibm.com> wrote:
>
> > I strongly object. Strongly and strenuously. DaveM, please,
> > please, please, leave those golden lines alone. The original
> > from Alexey is a work of art, humor, character and intelligence.
>
> I totally agree. In documentation and things for end users, fine.
> We can typo correct till the end of time. But for comments meant
> for programmers, let's keep it lively and humorous and sometimes
> flat out grammatically wrong. This is what gives it flavor makes
> it our's.
Okay.
But... Please apply the following patch.
I want to fix my error and mis-leading flags. :-P
Thanks.
===== net/ipv6/addrconf.c 1.91 vs edited =====
--- 1.91/net/ipv6/addrconf.c Tue Feb 3 03:31:58 2004
+++ edited/net/ipv6/addrconf.c Wed Feb 11 03:56:59 2004
@@ -1071,7 +1071,7 @@
eui[0] ^= 2;
return 0;
case ARPHRD_ARCNET:
- /* XXX: inherit EUI-64 fro mother interface -- yoshfuji */
+ /* XXX: inherit EUI-64 from other interface -- yoshfuji */
if (dev->addr_len != ARCNET_ALEN)
return -1;
memset(eui, 0, 7);
===== net/ipv6/ndisc.c 1.71 vs edited =====
--- 1.71/net/ipv6/ndisc.c Tue Feb 10 04:13:09 2004
+++ edited/net/ipv6/ndisc.c Wed Feb 11 04:00:28 2004
@@ -747,7 +747,7 @@
return;
}
- /* XXX: RFC2461 7.1.1:
+ /* RFC2461 7.1.1:
* If the IP source address is the unspecified address,
* there MUST NOT be source link-layer address option
* in the message.
@@ -1195,7 +1195,7 @@
return;
}
- /* XXX: RFC2461 8.1:
+ /* RFC2461 8.1:
* The IP source address of the Redirect MUST be the same as the current
* first-hop router for the specified ICMP Destination Address.
*/
--yoshfuji
next prev parent reply other threads:[~2004-02-10 19:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 18:28 [PATCH] IPV4: spelling correction YOSHIFUJI Hideaki / 吉藤英明
2004-02-10 18:30 ` Randy.Dunlap
2004-02-10 18:33 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-10 18:44 ` Nivedita Singhvi
2004-02-10 18:51 ` David S. Miller
2004-02-10 19:03 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2004-02-11 12:07 ` Arnaldo Carvalho de Melo
2004-02-11 13:41 ` jamal
2004-02-11 16:38 ` Nivedita Singhvi
2004-02-10 18:48 ` [PATCH] IPV4: spelling correction (Take 3) YOSHIFUJI Hideaki / 吉藤英明
2004-02-10 18:34 ` [PATCH] IPV4: spelling correction Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040211.040340.87331331.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).