netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
Subject: Re: [PATCH] IPV6: clean-up ndisc printk's
Date: Wed, 11 Feb 2004 11:18:23 -0800	[thread overview]
Message-ID: <20040211111823.2aa480b5.davem@redhat.com> (raw)
In-Reply-To: <20040211111616.34c18a2c.davem@redhat.com>

On Wed, 11 Feb 2004 11:16:16 -0800
"David S. Miller" <davem@redhat.com> wrote:

> On Tue, 10 Feb 2004 16:46:50 +0900 (JST)
> YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:
> 
> > D: print KERN_xxx appropriately.
> > D: put net_ratelimit() inside the macro.
> > D: re-arrange levels.

Actually, no, this makes GCC upset.  I have to revert the patch.

Please fix this:

net/ipv6/ndisc.c:1283:40: pasting "(" and "KERN_ERR" does not give a valid preprocessing token
net/ipv6/ndisc.c:1442:31: pasting "(" and "KERN_ERR" does not give a valid preprocessing token

Thanks.

      reply	other threads:[~2004-02-11 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-10  7:46 [PATCH] IPV6: clean-up ndisc printk's YOSHIFUJI Hideaki / 吉藤英明
2004-02-11 19:16 ` David S. Miller
2004-02-11 19:18   ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040211111823.2aa480b5.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).