From: "David S. Miller" <davem@redhat.com>
To: hadi@cyberus.ca
Cc: qnex@atlantis.knm.org.pl, netdev@oss.sgi.com, shemminger@osdl.org
Subject: Re: 2.6: QoS scheduling not working with IP-over-IP
Date: Wed, 11 Feb 2004 21:51:42 -0800 [thread overview]
Message-ID: <20040211215142.7f817513.davem@redhat.com> (raw)
In-Reply-To: <1076564638.1033.91.camel@jzny.localdomain>
On 12 Feb 2004 00:43:59 -0500
jamal <hadi@cyberus.ca> wrote:
> On Thu, 2004-02-12 at 00:25, jamal wrote:
>
> > > OK, however, old behavior would be like setting tx_queue_len to '1'.
> > > Do we wish to preserve this?
>
> I think i misunderstood you - you are saying maybe it was not a bug
> after all in pfifo, right? i.e the off by one is ok.
No, you understood me the first time.
I am saying, the PFIFO fix was correct. And therefore if we are to preserve
the tunnel device behavior precisely to what happened before the PFIFO fix
we must set the tx_queue_len to '1'.
What use is any other value? Show me a code path where more than one packet
can occupy the queue of one of these tunnel devices? :-)
Packets get headers added and straight to transmit to next device.
->hard_start_xmit() routines of these drivers always consume SKB and
return 0.
next prev parent reply other threads:[~2004-02-12 5:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0402101324350.810-100000@atlantis.knm.org.pl>
2004-02-12 4:05 ` 2.6: QoS scheduling not working with IP-over-IP David S. Miller
2004-02-12 4:51 ` jamal
2004-02-12 4:59 ` jamal
2004-02-12 5:04 ` jamal
2004-02-12 5:15 ` David S. Miller
2004-02-12 5:25 ` jamal
2004-02-12 5:43 ` jamal
2004-02-12 5:51 ` David S. Miller [this message]
2004-02-12 6:09 ` jamal
2004-02-12 6:22 ` David S. Miller
[not found] ` <402D54D6.5070708@trash.net>
2004-02-14 5:36 ` David S. Miller
2004-02-14 12:45 ` jamal
2004-02-14 13:06 ` jamal
2004-02-14 13:56 ` jamal
2004-02-14 20:49 ` David S. Miller
2004-02-15 10:30 ` Patrick McHardy
2004-02-18 3:10 ` David S. Miller
2004-02-18 11:21 ` Patrick McHardy
2004-02-18 21:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040211215142.7f817513.davem@redhat.com \
--to=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=qnex@atlantis.knm.org.pl \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).