From: Greg KH <greg@kroah.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Tommi Virtanen <tv@tv.debian.net>,
Leann Ogasawara <ogasawara@osdl.org>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] don't allow / in class device names
Date: Fri, 13 Feb 2004 12:59:36 -0800 [thread overview]
Message-ID: <20040213205936.GE14048@kroah.com> (raw)
In-Reply-To: <20040213124555.00cbf3d7@dell_ss3.pdx.osdl.net>
On Fri, Feb 13, 2004 at 12:45:55PM -0800, Stephen Hemminger wrote:
> > No, the "fix" is to just not do this in the driver. I'm not going to
> > apply this patch, sorry.
> >
> > thanks,
> >
> > greg k-h
>
> Bah, kernel API's should check there arguments. One of my peeve's about sysfs is
> that it is far too lazy about checking it's inputs. Especially, when the restrictions
> are not well documented, the code needs to validate.
But isn't a '/' character a valid character for a file or directory
name? :)
Yeah, it's pathalogical, but why burden the core from something that is
instantly obvious to the developer as a "wrong" thing to do?
It's much easier to see, "Oh, my driver created a stupid directory name
because of the string I told it to use", than "why in the world is the
driver core rejecting my register call when I _know_ it's a correct
structure".
thanks,
greg k-h
next prev parent reply other threads:[~2004-02-13 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-13 18:27 [PATCH] don't allow / in class device names Stephen Hemminger
2004-02-13 19:21 ` [PATCH] propogate errors from misc_register to caller Stephen Hemminger
2004-02-13 20:38 ` Greg KH
2004-02-20 0:23 ` Greg KH
2004-02-13 20:34 ` [PATCH] don't allow / in class device names Greg KH
2004-02-13 20:45 ` Stephen Hemminger
2004-02-13 20:59 ` Greg KH [this message]
2004-02-16 22:43 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040213205936.GE14048@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=ogasawara@osdl.org \
--cc=shemminger@osdl.org \
--cc=tv@tv.debian.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).