From: "David S. Miller" <davem@redhat.com>
To: "Mika Penttilä" <mika.penttila@kolumbus.fi>
Cc: jmorris@redhat.com, laforge@netfilter.org, netdev@oss.sgi.com,
sds@epoch.ncsc.mil
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
Date: Sat, 14 Feb 2004 15:00:41 -0800 [thread overview]
Message-ID: <20040214150041.5f6e7ef2.davem@redhat.com> (raw)
In-Reply-To: <402E71E2.1040508@kolumbus.fi>
On Sat, 14 Feb 2004 21:07:14 +0200
Mika Penttilä <mika.penttila@kolumbus.fi> wrote:
> This is unneeded overhead for the common case. The right fix is to make
> sure the modifier (netfilter etc) makes the copy if needed. Actually,
> this is what skb_ip_make_writable() is doing.
I totally agree.
In postrouting hook, the handler must unshare the SKB if it wishes to
modify the packet contents. It sounds to me like the selinux hooks are
not doing this, and as suggested they should look at using the routine
skb_ip_make_writable() which was designed by Rusty for this.
next prev parent reply other threads:[~2004-02-14 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-14 18:37 [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook James Morris
2004-02-14 18:37 ` Harald Welte
2004-02-14 19:07 ` Mika Penttilä
2004-02-14 23:00 ` David S. Miller [this message]
2004-02-15 6:09 ` James Morris
2004-02-15 9:34 ` Mika Penttilä
2004-02-15 13:03 ` James Morris
2004-02-15 13:40 ` Mika Penttilä
2004-02-15 14:03 ` James Morris
2004-02-15 16:00 ` Mika Penttilä
2004-02-16 1:50 ` James Morris
2004-02-16 6:43 ` Mika Penttilä
2004-02-16 13:45 ` James Morris
2004-02-19 1:24 ` David S. Miller
2004-02-23 22:19 ` James Morris
2004-02-29 5:50 ` David S. Miller
2004-02-17 15:54 ` Harald Welte
2004-02-17 20:35 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040214150041.5f6e7ef2.davem@redhat.com \
--to=davem@redhat.com \
--cc=jmorris@redhat.com \
--cc=laforge@netfilter.org \
--cc=mika.penttila@kolumbus.fi \
--cc=netdev@oss.sgi.com \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).