From: Stefan Rompf <srompf@isg.de>
To: netdev@oss.sgi.com
Cc: jgarzik@pobox.com, ionut@cs.columbia.edu
Subject: Patch: working suspend/resume for xircom_tulip_cb
Date: Sun, 15 Feb 2004 15:02:58 +0100 [thread overview]
Message-ID: <200402151502.59735.srompf@isg.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
Hi,
attached is a patch against 2.6.3rc2 that fixes suspend/resume for the
ethernet device of my Xircom RBEM56G-100 pc card. Previously, the driver did
not survive the resume operation. I still have problems when I remove the
card during suspend, but that yields to a different code path.
I could check with one laptop and one card, so the patch might need broader
testing, but it works nicely in my configuration.
Please apply if it looks ok.
Stefan
[-- Attachment #2: xircom_tulip_cb_pm.diff --]
[-- Type: text/x-diff, Size: 1503 bytes --]
--- drivers/net/tulip/xircom_tulip_cb.c.old 2004-02-14 14:33:03.000000000 +0100
+++ drivers/net/tulip/xircom_tulip_cb.c 2004-02-15 13:07:49.000000000 +0100
@@ -329,6 +329,9 @@ struct xircom_private {
int saved_if_port;
struct pci_dev *pdev;
spinlock_t lock;
+#ifdef CONFIG_PM
+ u32 pci_state[16];
+#endif
};
static int mdio_read(struct net_device *dev, int phy_id, int location);
@@ -749,6 +752,7 @@ xircom_up(struct net_device *dev)
long ioaddr = dev->base_addr;
int i;
+ xircom_init_ring(dev);
/* Clear the tx ring */
for (i = 0; i < TX_RING_SIZE; i++) {
tp->tx_skbuff[i] = 0;
@@ -801,8 +805,6 @@ xircom_open(struct net_device *dev)
if (request_irq(dev->irq, &xircom_interrupt, SA_SHIRQ, dev->name, dev))
return -EAGAIN;
- xircom_init_ring(dev);
-
xircom_up(dev);
tp->open = 1;
@@ -1668,6 +1670,11 @@ static int xircom_suspend(struct pci_dev
printk(KERN_INFO "xircom_suspend(%s)\n", dev->name);
if (tp->open)
xircom_down(dev);
+
+ pci_save_state(pdev, tp->pci_state);
+ pci_disable_device(pdev);
+ pci_set_power_state(pdev, 3);
+
return 0;
}
@@ -1678,6 +1685,10 @@ static int xircom_resume(struct pci_dev
struct xircom_private *tp = dev->priv;
printk(KERN_INFO "xircom_resume(%s)\n", dev->name);
+ pci_set_power_state(pdev,0);
+ pci_enable_device(pdev);
+ pci_restore_state(pdev, tp->pci_state);
+
/* Bring the chip out of sleep mode.
Caution: Snooze mode does not work with some boards! */
if (xircom_tbl[tp->chip_id].flags & HAS_ACPI)
reply other threads:[~2004-02-15 14:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402151502.59735.srompf@isg.de \
--to=srompf@isg.de \
--cc=ionut@cs.columbia.edu \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).