* [PATCH] wandev_show single_open confusion
@ 2004-02-19 19:27 Stephen Hemminger
2004-02-20 17:41 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2004-02-19 19:27 UTC (permalink / raw)
To: David S. Miller, Arnaldo Carvalho de Melo; +Cc: netdev
Fix single_open interface confusion in wanrouter. The argument passed
to single_open gets passed through via seq->private; not the void * argument
as assumed by this code.
diff -Nru a/net/wanrouter/wanproc.c b/net/wanrouter/wanproc.c
--- a/net/wanrouter/wanproc.c Thu Feb 19 11:24:49 2004
+++ b/net/wanrouter/wanproc.c Thu Feb 19 11:24:49 2004
@@ -207,7 +207,7 @@
static int wandev_show(struct seq_file *m, void *v)
{
- struct wan_device *wandev = v;
+ struct wan_device *wandev = m->private;
if (wandev->magic != ROUTER_MAGIC)
return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] wandev_show single_open confusion
2004-02-19 19:27 [PATCH] wandev_show single_open confusion Stephen Hemminger
@ 2004-02-20 17:41 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-02-20 17:41 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: acme, netdev
On Thu, 19 Feb 2004 11:27:05 -0800
Stephen Hemminger <shemminger@osdl.org> wrote:
> Fix single_open interface confusion in wanrouter. The argument passed
> to single_open gets passed through via seq->private; not the void * argument
> as assumed by this code.
Obviously correct, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-02-20 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-19 19:27 [PATCH] wandev_show single_open confusion Stephen Hemminger
2004-02-20 17:41 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).