* UDP counter doesn't increase
@ 2004-02-19 2:00 Takashi Hibi
2004-02-19 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Hibi @ 2004-02-19 2:00 UTC (permalink / raw)
To: netdev
Hi all,
UdpInDatagram in /proc/net/snmp6 doen't increase when IPv6 multicast
UDP packets are received.
sock_queue_rcv_skb() is called directly in udpv6_mcast_deliver. I think that
udpv6_queue_rcv_skb() should be called instead of sock_queue_rcv_skb()
as IPv4.
Regards,
Takashi Hibi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: UDP counter doesn't increase
2004-02-19 2:00 UDP counter doesn't increase Takashi Hibi
@ 2004-02-19 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-20 17:46 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-02-19 2:25 UTC (permalink / raw)
To: davem, hibi665; +Cc: netdev, yoshfuji
In article <20040219110035.2e1c15b4%hibi665@oki.com> (at Thu, 19 Feb 2004 11:00:35 +0900), Takashi Hibi <hibi665@oki.com> says:
> UdpInDatagram in /proc/net/snmp6 doen't increase when IPv6 multicast
> UDP packets are received.
> sock_queue_rcv_skb() is called directly in udpv6_mcast_deliver. I think that
> udpv6_queue_rcv_skb() should be called instead of sock_queue_rcv_skb()
> as IPv4.
Okay, here's the patch.
===== net/ipv6/udp.c 1.58 vs edited =====
--- 1.58/net/ipv6/udp.c Thu Jan 29 09:06:25 2004
+++ edited/net/ipv6/udp.c Thu Feb 19 11:22:46 2004
@@ -591,12 +591,12 @@
if (!buff)
continue;
}
- if (sock_queue_rcv_skb(sk2, buff) >= 0)
+ if (udpv6_queue_rcv_skb(sk2, buff) >= 0)
buff = NULL;
}
if (buff)
kfree_skb(buff);
- if (sock_queue_rcv_skb(sk, skb) < 0) {
+ if (udpv6_queue_rcv_skb(sk, skb) < 0) {
free_skb:
kfree_skb(skb);
}
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: UDP counter doesn't increase
2004-02-19 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2004-02-20 17:46 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2004-02-20 17:46 UTC (permalink / raw)
To: yoshfuji; +Cc: hibi665, netdev
On Thu, 19 Feb 2004 11:25:57 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:
> In article <20040219110035.2e1c15b4%hibi665@oki.com> (at Thu, 19 Feb 2004 11:00:35 +0900), Takashi Hibi <hibi665@oki.com> says:
>
> > UdpInDatagram in /proc/net/snmp6 doen't increase when IPv6 multicast
> > UDP packets are received.
> > sock_queue_rcv_skb() is called directly in udpv6_mcast_deliver. I think that
> > udpv6_queue_rcv_skb() should be called instead of sock_queue_rcv_skb()
> > as IPv4.
>
> Okay, here's the patch.
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-20 17:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-19 2:00 UDP counter doesn't increase Takashi Hibi
2004-02-19 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-20 17:46 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).