* Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot....
@ 2004-02-19 14:38 David Woodhouse
2004-02-20 6:22 ` David S. Miller
0 siblings, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2004-02-19 14:38 UTC (permalink / raw)
To: netdev
Putting IPv6 before IPv4 in net/Makefile fixes it, letting it IPv6
register its notifiers before the IPv4 ipconfig code brings up the
interface.
Objections?
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot....
2004-02-19 14:38 Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot David Woodhouse
@ 2004-02-20 6:22 ` David S. Miller
2004-02-20 19:01 ` David Woodhouse
2004-02-20 19:02 ` David Woodhouse
0 siblings, 2 replies; 6+ messages in thread
From: David S. Miller @ 2004-02-20 6:22 UTC (permalink / raw)
To: David Woodhouse; +Cc: netdev
On Thu, 19 Feb 2004 14:38:20 +0000
David Woodhouse <dwmw2@infradead.org> wrote:
> Putting IPv6 before IPv4 in net/Makefile fixes it, letting it IPv6
> register its notifiers before the IPv4 ipconfig code brings up the
> interface.
>
> Objections?
No objection. Send me a patch.
If at some point we create some initialization dependency between ipv4
and ipv6 (f.e. ipv6 init needs some ipv4 table setup) we will need to
tread carefully to keep this from breaking.
I did a quick audit and no such dependency exists now, so we can put in
the change without breaking anything.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot....
2004-02-20 6:22 ` David S. Miller
@ 2004-02-20 19:01 ` David Woodhouse
2004-02-20 19:07 ` David S. Miller
2004-02-20 19:02 ` David Woodhouse
1 sibling, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2004-02-20 19:01 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
On Thu, 2004-02-19 at 22:22 -0800, David S. Miller wrote:
> If at some point we create some initialization dependency between ipv4
> and ipv6 (f.e. ipv6 init needs some ipv4 table setup) we will need to
> tread carefully to keep this from breaking.
True. For 2.6 in fact we can do it this way...
===== net/ipv4/ipconfig.c 1.35 vs edited =====
--- 1.35/net/ipv4/ipconfig.c Wed Oct 8 01:37:44 2003
+++ edited/net/ipv4/ipconfig.c Fri Feb 20 19:00:23 2004
@@ -1324,7 +1324,7 @@
return 0;
}
-module_init(ip_auto_config);
+late_initcall(ip_auto_config);
/*
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot....
2004-02-20 6:22 ` David S. Miller
2004-02-20 19:01 ` David Woodhouse
@ 2004-02-20 19:02 ` David Woodhouse
2004-02-20 19:08 ` David S. Miller
1 sibling, 1 reply; 6+ messages in thread
From: David Woodhouse @ 2004-02-20 19:02 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
On Thu, 2004-02-19 at 22:22 -0800, David S. Miller wrote:
> On Thu, 19 Feb 2004 14:38:20 +0000
> David Woodhouse <dwmw2@infradead.org> wrote:
>
> > Putting IPv6 before IPv4 in net/Makefile fixes it, letting it IPv6
> > register its notifiers before the IPv4 ipconfig code brings up the
> > interface.
> >
> > Objections?
>
> No objection. Send me a patch.
For 2.4, which is the one I've actually tested...
===== net/Makefile 1.8 vs edited =====
--- 1.8/net/Makefile Fri Sep 19 12:07:29 2003
+++ edited/net/Makefile Fri Feb 20 19:02:04 2004
@@ -15,10 +15,10 @@
subdir-$(CONFIG_NET) += 802 sched netlink
+subdir-$(CONFIG_IPV6) += ipv6
subdir-$(CONFIG_INET) += ipv4
subdir-$(CONFIG_NETFILTER) += ipv4/netfilter
subdir-$(CONFIG_UNIX) += unix
-subdir-$(CONFIG_IPV6) += ipv6
subdir-$(CONFIG_IP_SCTP) += sctp
ifneq ($(CONFIG_IPV6),n)
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot....
2004-02-20 19:01 ` David Woodhouse
@ 2004-02-20 19:07 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2004-02-20 19:07 UTC (permalink / raw)
To: David Woodhouse; +Cc: netdev
On Fri, 20 Feb 2004 19:01:37 +0000
David Woodhouse <dwmw2@infradead.org> wrote:
> On Thu, 2004-02-19 at 22:22 -0800, David S. Miller wrote:
> > If at some point we create some initialization dependency between ipv4
> > and ipv6 (f.e. ipv6 init needs some ipv4 table setup) we will need to
> > tread carefully to keep this from breaking.
>
> True. For 2.6 in fact we can do it this way...
I like this version of this fix a lot, applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot....
2004-02-20 19:02 ` David Woodhouse
@ 2004-02-20 19:08 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2004-02-20 19:08 UTC (permalink / raw)
To: David Woodhouse; +Cc: netdev
On Fri, 20 Feb 2004 19:02:57 +0000
David Woodhouse <dwmw2@infradead.org> wrote:
> On Thu, 2004-02-19 at 22:22 -0800, David S. Miller wrote:
> > On Thu, 19 Feb 2004 14:38:20 +0000
> > David Woodhouse <dwmw2@infradead.org> wrote:
> >
> > > Putting IPv6 before IPv4 in net/Makefile fixes it, letting it IPv6
> > > register its notifiers before the IPv4 ipconfig code brings up the
> > > interface.
> > >
> > > Objections?
> >
> > No objection. Send me a patch.
>
> For 2.4, which is the one I've actually tested...
Also applied.
Thanks again David.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-02-20 19:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-19 14:38 Initialising net/ipv4/ before net/ipv6/ breaks IPv6 autoconf with nfsroot David Woodhouse
2004-02-20 6:22 ` David S. Miller
2004-02-20 19:01 ` David Woodhouse
2004-02-20 19:07 ` David S. Miller
2004-02-20 19:02 ` David Woodhouse
2004-02-20 19:08 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).