From: Stefan Rompf <srompf@isg.de>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: Patch: Make linkwatch more robust against rtnl holders
Date: Fri, 20 Feb 2004 17:44:21 +0100 [thread overview]
Message-ID: <200402201744.21348.srompf@isg.de> (raw)
In-Reply-To: <20040218171159.62e76670.davem@redhat.com>
Hi David,
> > the attached patch updates the linkwatch code so that it backs off and
> > retries whenever it cannot get the rtnl semaphore.
>
> I think we should fix locking conflicts created by things like what
> the sungem driver is doing instead.
On the other hand, I'm not aware of any convention when flush_scheduled_work()
is allowed to be called. As long as anyone inside kernel space is can
schedule work and anyone else can wait for completion, it does not hurt to
make a schedule task less vulnerable to deadlocks.
Stefan
prev parent reply other threads:[~2004-02-20 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-15 14:11 Patch: Make linkwatch more robust against rtnl holders Stefan Rompf
2004-02-19 1:11 ` David S. Miller
2004-02-19 1:18 ` Jeff Garzik
2004-02-20 16:44 ` Stefan Rompf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402201744.21348.srompf@isg.de \
--to=srompf@isg.de \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).