From: Andi Kleen <ak@muc.de>
To: "David S. Miller" <davem@redhat.com>
Cc: Andi Kleen <ak@muc.de>, netdev@oss.sgi.com, mostrows@styx.uwaterloo.ca
Subject: Re: [PATCH] Increase snd/rcv buffers in pppoe
Date: 23 Feb 2004 11:53:59 +0100
Date: Mon, 23 Feb 2004 11:53:59 +0100 [thread overview]
Message-ID: <20040223105359.GA91938@colin2.muc.de> (raw)
In-Reply-To: <20040222232601.481b8c57.davem@redhat.com>
On Sun, Feb 22, 2004 at 11:26:01PM -0800, David S. Miller wrote:
> On 23 Feb 2004 00:47:50 +0100
> Andi Kleen <ak@muc.de> wrote:
>
> > I noticed that a 64bit kernel only downloads half as fast over a PPPoE DSL
> > connection than a 32bit kernel on the same hardware. The reason seems
> > to be that PPPoE uses the default 64K snd/rcv buffers at socket creation.
> > The bigger sk_buff header size on the 64bit kernel pushed
> > the buffer into being too small and preventing good throughput.
>
> I have no problem with this, but hey while we're at it why not do the same
> for the core defaults instead? I see no real harm in this at all as it's
> not a pppoe specific issue.
The only issue I can think of is that it could be a problem for someone
with thousands of UDP (possible some other socket family) sockets. UDP doesn't
have the memory controls TCPs has to deal with that. Upping the defaults
to 128K could run him out of memory when many of the sockets are active
at the same time.
But increasing it to 128K is probably safe enough with the increased
memory sizes of today. Here's a new patch.
-Andi
diff -u linux-2.6.3-averell32/include/linux/skbuff.h-o linux-2.6.3-averell32/include/linux/skbuff.h
--- linux-2.6.3-averell32/include/linux/skbuff.h-o 2004-02-19 23:28:07.000000000 +0100
+++ linux-2.6.3-averell32/include/linux/skbuff.h 2004-02-25 12:42:07.000000000 +0100
@@ -271,8 +271,8 @@
*end;
};
-#define SK_WMEM_MAX 65535
-#define SK_RMEM_MAX 65535
+#define SK_WMEM_MAX 131072
+#define SK_RMEM_MAX 131072
#ifdef __KERNEL__
/*
next prev parent reply other threads:[~2004-02-23 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-22 23:47 [PATCH] Increase snd/rcv buffers in pppoe Andi Kleen
2004-02-23 7:26 ` David S. Miller
2004-02-23 10:53 ` Andi Kleen [this message]
2004-02-23 11:01 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-23 11:16 ` Andi Kleen
2004-02-23 11:38 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-23 18:26 ` David S. Miller
2004-02-23 20:12 ` Andi Kleen
2004-02-23 21:32 ` David S. Miller
2004-02-26 19:49 ` Andi Kleen
2004-02-26 20:42 ` David S. Miller
2004-02-26 20:52 ` Andi Kleen
2004-02-26 22:03 ` Andi Kleen
2004-02-26 22:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040223105359.GA91938@colin2.muc.de \
--to=ak@muc.de \
--cc=davem@redhat.com \
--cc=mostrows@styx.uwaterloo.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).