From: "David S. Miller" <davem@redhat.com>
To: James Morris <jmorris@redhat.com>
Cc: mika.penttila@kolumbus.fi, laforge@netfilter.org,
netdev@oss.sgi.com, sds@epoch.ncsc.mil
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
Date: Sat, 28 Feb 2004 21:50:13 -0800 [thread overview]
Message-ID: <20040228215013.28a61c76.davem@redhat.com> (raw)
In-Reply-To: <Xine.LNX.4.44.0402231713310.21153-100000@thoron.boston.redhat.com>
On Mon, 23 Feb 2004 17:19:03 -0500 (EST)
James Morris <jmorris@redhat.com> wrote:
> This does not seem to be the correct approach. If you drop packets in
> the ipsec cases at least, the retransmits just keep feeding packets back
> in with hardware checksumming set.
Ok, so TCP retransmits do this.
There is a check missing somewhere in the TCP output path then.
Or maybe, it refuses to mess with checksum state after the SKB
has been created, even for further retransmits.
More brainpower needed...
next prev parent reply other threads:[~2004-02-29 5:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-14 18:37 [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook James Morris
2004-02-14 18:37 ` Harald Welte
2004-02-14 19:07 ` Mika Penttilä
2004-02-14 23:00 ` David S. Miller
2004-02-15 6:09 ` James Morris
2004-02-15 9:34 ` Mika Penttilä
2004-02-15 13:03 ` James Morris
2004-02-15 13:40 ` Mika Penttilä
2004-02-15 14:03 ` James Morris
2004-02-15 16:00 ` Mika Penttilä
2004-02-16 1:50 ` James Morris
2004-02-16 6:43 ` Mika Penttilä
2004-02-16 13:45 ` James Morris
2004-02-19 1:24 ` David S. Miller
2004-02-23 22:19 ` James Morris
2004-02-29 5:50 ` David S. Miller [this message]
2004-02-17 15:54 ` Harald Welte
2004-02-17 20:35 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040228215013.28a61c76.davem@redhat.com \
--to=davem@redhat.com \
--cc=jmorris@redhat.com \
--cc=laforge@netfilter.org \
--cc=mika.penttila@kolumbus.fi \
--cc=netdev@oss.sgi.com \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).