netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: netdev@oss.sgi.com, jgarzik@pobox.com
Subject: Re: [janitor] use netdev_priv() in synclink (char. driver)
Date: Sat, 6 Mar 2004 20:16:40 -0800	[thread overview]
Message-ID: <20040306201640.7dd15986.rddunlap@osdl.org> (raw)
In-Reply-To: <1078499709.2076.5.camel@deimos.microgate.com>

On 05 Mar 2004 09:15:09 -0600 Paul Fulghum <paulkf@microgate.com> wrote:

| On Wed, 2004-03-03 at 17:01, Randy.Dunlap wrote:
| > | 
| > | From: Carlo Perassi <carlo@linux.it>
| > | and Randy.Dunlap <rddunlap@osdl.org>
| > 
| > 
| > Jeff, can you add this patch and the fusion/mptlan driver
| > patch as well?
| > 
| > --
| > ~Randy
| > 
| > 
| > 
[snip]
| > _
| 
| 
| This patch breaks the driver.
| 
| The pointer stored in dev->priv points to a structure that is
| allocated and maintained by the driver.
| 
| Changing from dev->priv to netdev_priv(dev) returns a pointer
| to memory at the end of the net_device structure.
| 
| These are two different things.
| 
| So with the patch, the driver gets a pointer to something
| other than the device private information that it needs.
| 
| Please dont apply this patch.

Yes, I see.

I appreciate you reviewing and catching that, Paul.

Thanks,
--
~Randy

  reply	other threads:[~2004-03-07  4:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040303142907.09d0f7bd.rddunlap@osdl.org>
     [not found] ` <20040303150105.7ff770b0.rddunlap@osdl.org>
2004-03-05 15:15   ` [janitor] use netdev_priv() in synclink (char. driver) Paul Fulghum
2004-03-07  4:16     ` Randy.Dunlap [this message]
     [not found] ` <20040303145738.293f987d.rddunlap@osdl.org>
2004-03-12 18:37   ` [janitor] use netdev_priv() in drivers/net/ (others) Jeff Garzik
2004-03-04 21:20 [janitor] use netdev_priv() in synclink (char. driver) Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040306201640.7dd15986.rddunlap@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=paulkf@microgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).