From: Olaf Kirch <okir@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: ip addr flush hangs
Date: Tue, 9 Mar 2004 20:47:56 +0100 [thread overview]
Message-ID: <20040309194756.GA11916@suse.de> (raw)
In-Reply-To: <20040309112529.4c013b9c.davem@redhat.com>
On Tue, Mar 09, 2004 at 11:25:29AM -0800, David S. Miller wrote:
> > The attached patch disables reporting of multicast and anycast
> > addresses in inet6_dump_ifaddr
>
> Better to fix /sbin/ip, Andi Kleen posted a patch for that tool
> in a thread on linux-kernel about this very issue.
His patch breaks ip addr flush completely, because it breaks the loop
before flushing the RTM_DELADDR packet to the netlink socket.
Even if you fix it to break out ofthe loop in the proper place, it is
still not entirely correct. ip does addr list and addr flush in a loop,
because netlink can return only so many addresses in one packet. If you
break out of the loop unconditionally, as Andi does in his patch, you
break ip addr list/flush for systems with more than the normal number
of addresses per device.
I think IPv6 is really wrong in reporting multicast addresses via
RTM_GETADDR. IPv4 doesn't do this either.
Olaf
--
Olaf Kirch | Stop wasting entropy - start using predictable
okir@suse.de | tempfile names today!
---------------+
next prev parent reply other threads:[~2004-03-09 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-09 14:48 ip addr flush hangs Olaf Kirch
2004-03-09 15:07 ` Olaf Kirch
2004-03-09 19:25 ` David S. Miller
2004-03-09 19:44 ` Andi Kleen
2004-03-09 19:46 ` David S. Miller
2004-03-09 19:47 ` Olaf Kirch [this message]
2004-03-09 23:29 ` David S. Miller
2004-03-09 23:56 ` Shirley Ma
2004-03-10 0:06 ` David S. Miller
2004-03-10 3:32 ` YOSHIFUJI Hideaki / 吉藤英明
2004-03-10 7:59 ` Shirley Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040309194756.GA11916@suse.de \
--to=okir@suse.de \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).