Re: linux-wireless mailing list

[Jean Tourrilhes <jt@bougret.hpl.hp.com>]

On Wed, Mar 10, 2004 at 01:25:48PM -0500, Jeff Garzik wrote:
> 
> A type-specific wireless_ops is something that I definitely want to see.
> 
> It reduces code in the drivers, by increasing the amount of code that 
> can be made generic.  It's much better to, for example, have all the 
> user data (length, etc.) validate checks, and capable(CAP_xxx) security 
> checks all in one place.  And perhaps more importantly, a type-specific 
> wireless_ops makes it harder for driver writers to screw up ;-)  That's 
> an important attribute in a driver API, I've come to learn...

	You could define a set of wrapper that would convert from
iw_handler to a type specific call. This is already what is done in
the case of iwspy support ; the driver just adds in the iw_handler
table the generic spy handlers provided in wireless.c. You can check
in airo.c around line 6823.
	But honestly, I believe that there are other more urgent
things to do (such as WPA support for example).

> 	Jeff

	Jean