From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: maxk@qualcomm.com, vtun@office.satix.net.sgi.com, netdev@oss.sgi.com
Subject: Re: [PATCH] tun
Date: Mon, 15 Mar 2004 12:47:51 -0800 [thread overview]
Message-ID: <20040315124751.4808bf45.davem@redhat.com> (raw)
In-Reply-To: <20040315102810.2111a5d7@dell_ss3.pdx.osdl.net>
On Mon, 15 Mar 2004 10:28:10 -0800
Stephen Hemminger <shemminger@osdl.org> wrote:
> Tun verifies the user address before doing memcpy_from/toiovec. There are
> two problems with this strategy. First, it is possible on an SMP machine
> to construct cases where a page is unmmapped between the verify and the copy,
> and it is also faster to do the verification only once.
Yes, those verify_area calls are superfluous and racy.
Applied, thanks Stephen.
prev parent reply other threads:[~2004-03-15 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 18:28 [PATCH] tun Stephen Hemminger
2004-03-15 20:47 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315124751.4808bf45.davem@redhat.com \
--to=davem@redhat.com \
--cc=maxk@qualcomm.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
--cc=vtun@office.satix.net.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).