From: "David S. Miller" <davem@redhat.com>
To: timg@tpi.com
Cc: anton@samba.org, netdev@oss.sgi.com, linux-net@vger.kernel.org
Subject: Re: [PATCH} ARP auto-sizing for 2.4.24 - 2.4.26-pre3
Date: Mon, 15 Mar 2004 13:44:12 -0800 [thread overview]
Message-ID: <20040315134412.314b5e23.davem@redhat.com> (raw)
In-Reply-To: <200403141210.57266.timg@tpi.com>
Two problems:
1) Don't do the config option thing if we're going to auto-size.
2) Your ram_mb calcs use PAGE_SIZE as a term, and therefore assume
it has a value of 4096 or somesuch. Please remove this assumption.
To be honest, while I'm not against making the tables a little bigger,
for ARP "WHO THE FUCK CARES" if another 100 cycles or so are burnt on
a lookup. What setup do you have where ARP performance is a real issue?
Your original email was nice in describing the fact that ARP does not
scale, but you've made no foundation on which to erect a claim that
scalability for ARP (and thus the added complexity/changes) is even
necessary.
next prev parent reply other threads:[~2004-03-15 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 19:10 [PATCH} ARP auto-sizing for 2.4.24 - 2.4.26-pre3 Tim Gardner
2004-03-15 21:44 ` David S. Miller [this message]
2004-03-15 21:55 ` Pekka Savola
2004-03-15 21:57 ` David S. Miller
2004-03-15 22:21 ` Pekka Savola
2004-03-15 22:00 ` Andi Kleen
2004-03-16 16:05 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315134412.314b5e23.davem@redhat.com \
--to=davem@redhat.com \
--cc=anton@samba.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=timg@tpi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).