* netpoll warning in tulip
@ 2004-03-16 10:36 Meelis Roos
2004-03-16 19:23 ` Matt Mackall
0 siblings, 1 reply; 3+ messages in thread
From: Meelis Roos @ 2004-03-16 10:36 UTC (permalink / raw)
To: netdev
FYI: with netpoll configured out, I get
CC [M] drivers/net/tulip/tulip_core.o
drivers/net/tulip/tulip_core.c:256: warning: `poll_tulip' declared `static' but never defined
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: netpoll warning in tulip
2004-03-16 10:36 netpoll warning in tulip Meelis Roos
@ 2004-03-16 19:23 ` Matt Mackall
2004-03-16 20:37 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Matt Mackall @ 2004-03-16 19:23 UTC (permalink / raw)
To: Meelis Roos; +Cc: netdev, Jeff Garzik
On Tue, Mar 16, 2004 at 12:36:02PM +0200, Meelis Roos wrote:
> FYI: with netpoll configured out, I get
>
> CC [M] drivers/net/tulip/tulip_core.o
> drivers/net/tulip/tulip_core.c:256: warning: `poll_tulip' declared `static' but never defined
2.6.5-rc1-mpm/drivers/net/tulip/tulip_core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/net/tulip/tulip_core.c~tulip-poll drivers/net/tulip/tulip_core.c
--- 2.6.5-rc1/drivers/net/tulip/tulip_core.c~tulip-poll 2004-03-16 13:21:38.000000000 -0600
+++ 2.6.5-rc1-mpm/drivers/net/tulip/tulip_core.c 2004-03-16 13:22:30.000000000 -0600
@@ -253,8 +253,9 @@ static void tulip_down(struct net_device
static struct net_device_stats *tulip_get_stats(struct net_device *dev);
static int private_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
static void set_rx_mode(struct net_device *dev);
+#ifdef CONFIG_NET_POLL_CONTROLLER
static void poll_tulip(struct net_device *dev);
-
+#endif
static void tulip_set_power_state (struct tulip_private *tp,
int sleep, int snooze)
_
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: netpoll warning in tulip
2004-03-16 19:23 ` Matt Mackall
@ 2004-03-16 20:37 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2004-03-16 20:37 UTC (permalink / raw)
To: Matt Mackall; +Cc: Meelis Roos, netdev
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-03-16 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-16 10:36 netpoll warning in tulip Meelis Roos
2004-03-16 19:23 ` Matt Mackall
2004-03-16 20:37 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).