From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h Date: Tue, 16 Mar 2004 20:17:10 +0000 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040316201710.A9931@flint.arm.linux.org.uk> References: <1079369568.19012.100.camel@icampbell-debian> <20040316001141.C29594@flint.arm.linux.org.uk> <20040316192247.A7886@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ian Campbell , netdev@oss.sgi.com, Linux Kernel Mailing List Return-path: To: Linus Torvalds Content-Disposition: inline In-Reply-To: ; from torvalds@osdl.org on Tue, Mar 16, 2004 at 11:34:56AM -0800 Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Tue, Mar 16, 2004 at 11:34:56AM -0800, Linus Torvalds wrote: > On Tue, 16 Mar 2004, Russell King wrote: > > > > > > What are your thoughts on this? > > > > So how do we solve this problem. Should I just merge this change and > > ask you to pull it? I think that's rather impolite though. > > I didn't apply the patch because you said it was untested ;) Ok, I've now tested the removal of linux/irq.h from netpoll.h and it built fine for me on ARM. However, whether there's a reason for it to be there on x86 or not still remains to be proven. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core