From: Adrian Bunk <bunk@fs.tum.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Ian Campbell <icampbell@arcom.com>,
netdev@oss.sgi.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h
Date: Tue, 16 Mar 2004 21:27:46 +0100 [thread overview]
Message-ID: <20040316202746.GO27056@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0403161133430.17272@ppc970.osdl.org>
On Tue, Mar 16, 2004 at 11:34:56AM -0800, Linus Torvalds wrote:
>
>
> On Tue, 16 Mar 2004, Russell King wrote:
> > >
> > > What are your thoughts on this?
> >
> > So how do we solve this problem. Should I just merge this change and
> > ask you to pull it? I think that's rather impolite though.
>
> I didn't apply the patch because you said it was untested ;)
>
> I'll happily remove that irq.h include if it really doesn't do anything
> but break things. I'd feel happier about it if somebody said it has been
> tested, though ;)
I removed the irq.h from netpoll.h in a 2.6.5-rc1-mm1 that was compiled
with a i386 .config that compiles as much as possible statically into
the kernel.
There were no compilation problems.
> Linus
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2004-03-16 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 16:52 [PATCH] Do not include linux/irq.h from linux/netpoll.h Ian Campbell
2004-03-16 0:11 ` Russell King
2004-03-16 19:22 ` Russell King
2004-03-16 19:31 ` Christoph Hellwig
2004-03-16 19:34 ` Linus Torvalds
2004-03-16 19:41 ` Russell King
2004-03-16 20:17 ` Russell King
2004-03-16 20:27 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316202746.GO27056@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=icampbell@arcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).