From: Andrew Morton <akpm@osdl.org>
To: "YOSHIFUJI Hideaki / ____________" <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, netdev@oss.sgi.com, mru@kth.se
Subject: Re: [BUG] alignment problem in net/core/flow.c:flow_key_compare
Date: Thu, 18 Mar 2004 18:59:40 -0800 [thread overview]
Message-ID: <20040318185940.45108d6a.akpm@osdl.org> (raw)
In-Reply-To: <20040319.115511.32395995.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / ____________ <yoshfuji@linux-ipv6.org> wrote:
>
>
> +#if (BITS_PER_LONG == 64)
> +#define FLOWI_ALIGN_BYTES 8
> +#else
> +#define FLOWI_ALIGN_BYTES 4
> +#endif
> +
> struct flowi {
> int oif;
> int iif;
> @@ -77,7 +83,7 @@
> #define fl_icmp_type uli_u.icmpt.type
> #define fl_icmp_code uli_u.icmpt.code
> #define fl_ipsec_spi uli_u.spi
> -};
> +} __attribute__((__aligned__(FLOWI_ALIGN_BYTES)));
>
Why not simply
> +} __attribute__((__aligned__(BITS_PER_LONG/8)));
?
next prev parent reply other threads:[~2004-03-19 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:29 Fw: [BUG] alignment problem in net/core/flow.c:flow_key_compare Andrew Morton
2004-03-19 2:55 ` YOSHIFUJI Hideaki / 吉藤英明
2004-03-19 2:59 ` Andrew Morton [this message]
2004-03-19 4:21 ` David S. Miller
2004-03-19 5:00 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040318185940.45108d6a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=mru@kth.se \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).