From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: BUG in tcp_timer.c:tcp_retransmit_timer() Date: Mon, 29 Mar 2004 21:50:57 -0800 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040329215057.3fd40210.davem@redhat.com> References: <20040329200954.7baac255.davem@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-net@vger.kernel.org, netdev@oss.sgi.com Return-path: To: "Tomar, Nagendra" In-Reply-To: Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Mon, 29 Mar 2004 22:54:14 +0530 (IST) Nagendra Singh Tomar wrote: > Thats right. But what about the other cases of retransmission > failures for which we are having a negative return (-ENOMEM, -EAGAIN, > -EHOSTUNREACH etc). Even for these cases its not a good idea to > artificially increment tp->retransmits, lest in some extreme case we might > timeout a connection without a single packet going on the wire. That's just like the packet getting dropped at the next hop, and not the case this branch of code intends to deal with.