* [PATCH] eliminate divert_blk message
@ 2004-04-05 15:03 Olaf Kirch
2004-04-05 16:19 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Kirch @ 2004-04-05 15:03 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
Every time a non-ethernet device is configured (e.g. when using PPP) the
kernel logs a message saying "not allocating divert_blk for non-ethernet
device". This patch disables the message.
Cheers,
Olaf
--
Olaf Kirch | The Hardware Gods hate me.
okir@suse.de |
---------------+
[-- Attachment #2: divert_blk-shutup --]
[-- Type: text/plain, Size: 340 bytes --]
--- linux-2.6.4/net/core/dv.c.quiet 2004-02-04 04:43:45.000000000 +0100
+++ linux-2.6.4/net/core/dv.c 2004-04-05 16:50:06.000000000 +0200
@@ -67,9 +67,6 @@
}
dev_hold(dev);
} else {
- printk(KERN_DEBUG "divert: not allocating divert_blk for non-ethernet device %s\n",
- dev->name);
-
dev->divert = NULL;
}
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] eliminate divert_blk message
2004-04-05 15:03 [PATCH] eliminate divert_blk message Olaf Kirch
@ 2004-04-05 16:19 ` Andi Kleen
2004-04-05 16:20 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2004-04-05 16:19 UTC (permalink / raw)
To: Olaf Kirch; +Cc: netdev
On Mon, 5 Apr 2004 17:03:12 +0200
Olaf Kirch <okir@suse.de> wrote:
> Every time a non-ethernet device is configured (e.g. when using PPP) the
> kernel logs a message saying "not allocating divert_blk for non-ethernet
> device". This patch disables the message.
Are you sure? All our kernels have CONFIG_NET_DIVERT disabled. I don't see
how you could get this message unless you enabled it on your own.
If you did that just disable it, it's imho an useless option.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] eliminate divert_blk message
2004-04-05 16:19 ` Andi Kleen
@ 2004-04-05 16:20 ` Andi Kleen
0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2004-04-05 16:20 UTC (permalink / raw)
To: Andi Kleen; +Cc: okir, netdev
On Mon, 5 Apr 2004 18:19:25 +0200
Andi Kleen <ak@suse.de> wrote:
> On Mon, 5 Apr 2004 17:03:12 +0200
> Olaf Kirch <okir@suse.de> wrote:
>
> > Every time a non-ethernet device is configured (e.g. when using PPP) the
> > kernel logs a message saying "not allocating divert_blk for non-ethernet
> > device". This patch disables the message.
>
> Are you sure? All our kernels have CONFIG_NET_DIVERT disabled. I don't see
> how you could get this message unless you enabled it on your own.
> If you did that just disable it, it's imho an useless option.
Oops, that should have gone to Olaf privately. Sorry for the noise.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-05 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-05 15:03 [PATCH] eliminate divert_blk message Olaf Kirch
2004-04-05 16:19 ` Andi Kleen
2004-04-05 16:20 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).