From: Francois Romieu <romieu@fr.zoreil.com>
To: bhartin@straus-frank.com
Cc: netdev@oss.sgi.com
Subject: Re: r8169, 2.6.2-rc2, Sager 4780 laptop
Date: Wed, 7 Apr 2004 01:38:41 +0200 [thread overview]
Message-ID: <20040407013841.A7978@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0404061758570.17117@edp12.straus-frank.int>; from bhartin@straus-frank.com on Tue, Apr 06, 2004 at 06:03:03PM -0500
bhartin@straus-frank.com <bhartin@straus-frank.com> :
[...]
> I got my laptop back up and found the messages logged:
>
> kernel: r8169: eth0: Reset RTL8169s PHY
>
> I didn't see exactly at what point this started happening during the
> shutdown, but the message repeated about 500 times before the system
> logger was stopped.
It implies a minimum of 6000 invocations of rtl8169_phy_timer().
*doh*
Please apply patch below.
mod_timer() expects an absolute time, not a relative offset.
drivers/net/r8169.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/r8169.c~r8169-mod_timer drivers/net/r8169.c
--- linux-2.6.5/drivers/net/r8169.c~r8169-mod_timer 2004-04-07 01:30:14.000000000 +0200
+++ linux-2.6.5-fr/drivers/net/r8169.c 2004-04-07 01:32:53.000000000 +0200
@@ -617,7 +617,7 @@ static void rtl8169_phy_timer(unsigned l
}
}
- mod_timer(timer, RTL8169_PHY_TIMEOUT);
+ mod_timer(timer, jiffies + RTL8169_PHY_TIMEOUT);
}
static inline void rtl8169_delete_timer(struct net_device *dev)
_
next prev parent reply other threads:[~2004-04-06 23:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-26 21:19 r8169, 2.6.2-rc2, Sager 4780 laptop bhartin
2004-01-26 22:55 ` Francois Romieu
2004-01-27 6:51 ` bhartin
2004-04-04 21:05 ` bhartin
2004-04-04 22:20 ` Francois Romieu
2004-04-04 23:57 ` bhartin
[not found] ` <Pine.LNX.4.58.0404061650310.20664@edp12.straus-frank.int>
[not found] ` <20040407001815.C7833@electric-eye.fr.zoreil.com>
2004-04-06 23:03 ` bhartin
2004-04-06 23:38 ` Francois Romieu [this message]
2004-04-07 5:15 ` bhartin
2004-04-07 9:26 ` Francois Romieu
2004-04-07 13:43 ` bhartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040407013841.A7978@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bhartin@straus-frank.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).