netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: netdev@oss.sgi.com
Subject: [PATCH] eliminate useless divert message
Date: Wed, 7 Apr 2004 12:29:12 -0400	[thread overview]
Message-ID: <20040407162912.GA21868@achilles.net> (raw)

[sorry if this is a dupe, but the original wasn't going through.]

Hello folks,

Debugging some ppp code has made me truely despise divert's log messages.  
This patch deletes both the allocate and delete printks.

		-ben
-- 
"Time is what keeps everything from happening all at once." -- John Wheeler


===== net/core/dv.c 1.9 vs edited =====
--- 1.9/net/core/dv.c	Sun Sep 28 19:47:07 2003
+++ edited/net/core/dv.c	Tue Apr  6 22:17:12 2004
@@ -53,9 +53,6 @@
 	int alloc_size = (sizeof(struct divert_blk) + 3) & ~3;
 
 	if (dev->type == ARPHRD_ETHER) {
-		printk(KERN_DEBUG "divert: allocating divert_blk for %s\n",
-		       dev->name);
-
 		dev->divert = (struct divert_blk *)
 			kmalloc(alloc_size, GFP_KERNEL);
 		if (dev->divert == NULL) {
@@ -67,9 +64,6 @@
 		}
 		dev_hold(dev);
 	} else {
-		printk(KERN_DEBUG "divert: not allocating divert_blk for non-ethernet device %s\n",
-		       dev->name);
-
 		dev->divert = NULL;
 	}
 	return 0;

                 reply	other threads:[~2004-04-07 16:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040407162912.GA21868@achilles.net \
    --to=bcrl@kvack.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).