From: Francois Romieu <romieu@fr.zoreil.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: [patch 2/3] 2.6.5-netdev2 - r8169 update
Date: Wed, 7 Apr 2004 23:15:29 +0200 [thread overview]
Message-ID: <20040407231529.B25867@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20040407231444.A25867@electric-eye.fr.zoreil.com>; from romieu@fr.zoreil.com on Wed, Apr 07, 2004 at 11:14:44PM +0200
The irq handler must not return 1 when the status register is null
during the firt iteration.
drivers/net/r8169.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/net/r8169.c~r8169-irq-handler-status drivers/net/r8169.c
--- linux-2.6.5/drivers/net/r8169.c~r8169-irq-handler-status 2004-04-07 22:56:57.000000000 +0200
+++ linux-2.6.5-fr/drivers/net/r8169.c 2004-04-07 22:58:21.000000000 +0200
@@ -1540,8 +1540,8 @@ rtl8169_interrupt(int irq, void *dev_ins
do {
status = RTL_R16(IntrStatus);
- /* h/w no longer present (hotplug?) or major error, bail */
- if (status == 0xFFFF)
+ /* hotplug/major error/no more work/shared irq */
+ if ((status == 0xFFFF) || !status)
break;
handled = 1;
_
next prev parent reply other threads:[~2004-04-07 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-05 21:55 [patch 0/7] 2.6.5-bk-netdev - r8169 queue Francois Romieu
2004-04-05 21:56 ` [patch 1/7] " Francois Romieu
2004-04-05 21:57 ` [patch 2/7] " Francois Romieu
2004-04-05 21:58 ` [patch 3/7] " Francois Romieu
2004-04-05 21:58 ` [patch 4/7] " Francois Romieu
2004-04-05 21:59 ` [patch 5/7] " Francois Romieu
2004-04-05 21:59 ` [patch 6/7] " Francois Romieu
2004-04-05 22:00 ` [patch 7/7] " Francois Romieu
2004-04-07 21:13 ` [patch 0/3] 2.6.5-netdev2 - r8169 update Francois Romieu
2004-04-07 21:14 ` [patch 1/3] " Francois Romieu
2004-04-07 21:15 ` Francois Romieu [this message]
2004-04-07 21:16 ` [patch 3/3] " Francois Romieu
2004-04-13 18:27 ` [patch 1/3] " Jeff Garzik
2004-04-13 23:42 ` [patch 0/3] " Srihari Vijayaraghavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040407231529.B25867@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).