From: "David S. Miller" <davem@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: netdev@oss.sgi.com, tspat@de.ibm.com, shemminger@osdl.org
Subject: Re: [PATCH] Force IPv6 FIB gc on device shutdown
Date: Fri, 9 Apr 2004 15:31:17 -0700 [thread overview]
Message-ID: <20040409153117.490c9ba3.davem@redhat.com> (raw)
In-Reply-To: <20040409173901.62ebf75b.ak@suse.de>
Thanks Andi.
A week ago Thomas Spatzier posted a similar patch, and I had
asked Stephen Hemminger (in private email) for his take on
this.
So here is the final patch I applied, based upon your and
Thomas's patches, plus Stephen's commentary. (hint: NETDEV_DOWN
is sufficient, because unregister causes a NETDEV_DOWN event
if necessary).
Thanks everyone.
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/04/09 15:29:23-07:00 davem@nuts.davemloft.net
# [IPV6]: In ndisc_netdev_event, handle NETDEV_DOWN.
#
# Based upon patches and commentary from Thomas Spatzier,
# Stephen Hemminger, and Andi Kleen.
#
# net/ipv6/ndisc.c
# 2004/04/09 15:29:00-07:00 davem@nuts.davemloft.net +4 -0
# [IPV6]: In ndisc_netdev_event, handle NETDEV_DOWN.
#
# Based upon patches and commentary from Thomas Spatzier,
# Stephen Hemminger, and Andi Kleen.
#
diff -Nru a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
--- a/net/ipv6/ndisc.c Fri Apr 9 15:30:59 2004
+++ b/net/ipv6/ndisc.c Fri Apr 9 15:30:59 2004
@@ -1403,6 +1403,10 @@
neigh_changeaddr(&nd_tbl, dev);
fib6_run_gc(0);
break;
+ case NETDEV_DOWN:
+ neigh_ifdown(&nd_tbl, dev);
+ fib6_run_gc(0);
+ break;
default:
break;
}
prev parent reply other threads:[~2004-04-09 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-09 15:39 [PATCH] Force IPv6 FIB gc on device shutdown Andi Kleen
2004-04-09 22:31 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040409153117.490c9ba3.davem@redhat.com \
--to=davem@redhat.com \
--cc=ak@suse.de \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
--cc=tspat@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).