From: "David S. Miller" <davem@redhat.com>
To: chas3@users.sourceforge.net
Cc: chas@cmf.nrl.navy.mil, netdev@oss.sgi.com
Subject: Re: [PATCH][ATM]: [nicstar] using dev_alloc_skb() (reported by "Johnston, Jayme" <Jayme.Johnston@siemens.com>)
Date: Fri, 9 Apr 2004 16:38:18 -0700 [thread overview]
Message-ID: <20040409163818.7e2b6f71.davem@redhat.com> (raw)
In-Reply-To: <200404071211.i37CB3gK020805@ginger.cmf.nrl.navy.mil>
On Wed, 07 Apr 2004 08:11:04 -0400
"chas williams (contractor)" <chas@cmf.nrl.navy.mil> wrote:
> the nicstar driver has typically used alloc_skb() to get its i/o buffers.
> since these buffers are likely to be passed to the network stack at some
> point it should probably be using dev_alloc_skb(). this patches fixes
> a crash during pppoatm operation when an unchecked skb_push() operates on
> a buffer returned by the nicstar.
>
> please apply to 2.6 and 2.4 kernels (and if at all possible could
> i get this in the soon to be released 2.4.26 kernel?)
Good catch, applied.
I'll do my best to get Marcelo to eats this soon, but no promises.
:-)
prev parent reply other threads:[~2004-04-09 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-07 12:11 [PATCH][ATM]: [nicstar] using dev_alloc_skb() (reported by "Johnston, Jayme" <Jayme.Johnston@siemens.com>) chas williams (contractor)
2004-04-09 23:38 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040409163818.7e2b6f71.davem@redhat.com \
--to=davem@redhat.com \
--cc=chas3@users.sourceforge.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).