From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: ak@suse.de
Cc: davem@redhat.com, netdev@oss.sgi.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] NETDEBUG network triggerable messages in IPv6
Date: Sat, 10 Apr 2004 02:47:05 +0900 (JST) [thread overview]
Message-ID: <20040410.024705.97089877.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20040409193123.63e4cdc7.ak@suse.de>
In article <20040409193123.63e4cdc7.ak@suse.de> (at Fri, 9 Apr 2004 19:31:23 +0200), Andi Kleen <ak@suse.de> says:
> > I don't like the style; it is too ugly.
> > E.g. please do not put "if () ..." into the macro argument.
>
> Ok, here is a new version that defines a new macro LIMIT_NETDEBUG that does the
> rate limit implicitely.
> - if (net_ratelimit())
> - printk(KERN_WARNING "overrun destopt\n");
> + LIMIT_NETDEBUG(
> + printk(KERN_WARNING "overrun destopt\n"));
Grr...
I'd prefer:
if (net_ratelimit())
NETDEBUG_PRINTK("overrun destopt\n"..)
or
NETDEBUG_PRINTK_LIMIT("overrun destopt\n"..)
(or something like this) much more.
--yoshfuji
next prev parent reply other threads:[~2004-04-09 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-09 15:48 [PATCH] NETDEBUG network triggerable messages in IPv6 Andi Kleen
2004-04-09 16:00 ` YOSHIFUJI Hideaki / 吉藤英明
2004-04-09 16:21 ` Andi Kleen
2004-04-09 17:18 ` YOSHIFUJI Hideaki / 吉藤英明
2004-04-09 17:31 ` Andi Kleen
2004-04-09 17:47 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2004-04-09 17:50 ` Andi Kleen
2004-04-09 18:09 ` YOSHIFUJI Hideaki / 吉藤英明
2004-04-09 18:24 ` Andi Kleen
2004-04-16 20:52 ` David S. Miller
2004-04-09 18:06 ` Nivedita Singhvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040410.024705.97089877.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=ak@suse.de \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).