From: Jeremy Martin <martinjd@csc.uvic.ca>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix tuntap oversight
Date: Mon, 12 Apr 2004 09:29:16 -0700 [thread overview]
Message-ID: <20040412162916.GA5046@net-ronin.org> (raw)
In-Reply-To: <20040412001551.05476658.davem@redhat.com>
On Mon, Apr 12, 2004 at 12:15:51AM -0700, David S. Miller wrote:
>
> This netif_running() check is not necessary, and in fact
> wrong.
>
> In fact, if ethernet drivers erroneously do this, this causes
> them to fail to support the ALB bonding driver modes which
> require on-the-fly MAC address changes while the interface is
> up.
>
I just took a look in drivers/net/
and
acenic.c
atarilance.c
b44.c
cs89x0.c
net_init.c
typhoon.c
all use that netif_running() check when setting the MAC. I actually just pulled
the function from net_init.c for the tun change. Are these broken?
(I'm asking in total ignorance so be gentle :).
-Jeremy
next prev parent reply other threads:[~2004-04-12 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-12 6:59 [PATCH] fix tuntap oversight Jeremy Martin
2004-04-12 7:15 ` David S. Miller
2004-04-12 16:29 ` Jeremy Martin [this message]
2004-04-12 16:43 ` Jeff Garzik
2004-04-12 17:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040412162916.GA5046@net-ronin.org \
--to=martinjd@csc.uvic.ca \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).