* [PATCH] Propagate error from sctp_proc_init
@ 2004-04-14 13:41 Olaf Kirch
2004-04-14 22:09 ` Sridhar Samudrala
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Kirch @ 2004-04-14 13:41 UTC (permalink / raw)
To: netdev; +Cc: lksctp-developers
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
The following patch makes sure that an error in sctp_proc_init()
causes module initialization to fail.
Olaf
--
Olaf Kirch | The Hardware Gods hate me.
okir@suse.de |
---------------+
[-- Attachment #2: sctp-initfail --]
[-- Type: text/plain, Size: 581 bytes --]
--- linux-2.6.4/net/sctp/protocol.c.initfail 2004-02-19 11:36:37.000000000 +0100
+++ linux-2.6.4/net/sctp/protocol.c 2004-04-14 15:36:19.000000000 +0200
@@ -1001,7 +1001,9 @@
goto err_init_mibs;
/* Initialize proc fs directory. */
- sctp_proc_init();
+ status = sctp_proc_init();
+ if (status)
+ goto err_init_proc;
/* Initialize object count debugging. */
sctp_dbg_objcnt_init();
@@ -1165,6 +1167,7 @@
sizeof(struct sctp_hashbucket)));
err_ahash_alloc:
sctp_dbg_objcnt_exit();
+err_init_proc:
sctp_proc_exit();
cleanup_sctp_mibs();
err_init_mibs:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Propagate error from sctp_proc_init
2004-04-14 13:41 [PATCH] Propagate error from sctp_proc_init Olaf Kirch
@ 2004-04-14 22:09 ` Sridhar Samudrala
0 siblings, 0 replies; 2+ messages in thread
From: Sridhar Samudrala @ 2004-04-14 22:09 UTC (permalink / raw)
To: Olaf Kirch; +Cc: netdev, lksctp-developers
The patch looks fine. Dave, could you apply it both 2.6 and 2.4 trees.
It should apply to both of them with a little fuzz.
Thanks
Sridhar
On Wed, 14 Apr 2004, Olaf Kirch wrote:
> The following patch makes sure that an error in sctp_proc_init()
> causes module initialization to fail.
>
> Olaf
> --
> Olaf Kirch | The Hardware Gods hate me.
> okir@suse.de |
> ---------------+
>
--- linux-2.6.4/net/sctp/protocol.c.initfail 2004-02-19 11:36:37.000000000 +0100
+++ linux-2.6.4/net/sctp/protocol.c 2004-04-14 15:36:19.000000000 +0200
@@ -1001,7 +1001,9 @@
goto err_init_mibs;
/* Initialize proc fs directory. */
- sctp_proc_init();
+ status = sctp_proc_init();
+ if (status)
+ goto err_init_proc;
/* Initialize object count debugging. */
sctp_dbg_objcnt_init();
@@ -1165,6 +1167,7 @@
sizeof(struct sctp_hashbucket)));
err_ahash_alloc:
sctp_dbg_objcnt_exit();
+err_init_proc:
sctp_proc_exit();
cleanup_sctp_mibs();
err_init_mibs:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-04-14 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-14 13:41 [PATCH] Propagate error from sctp_proc_init Olaf Kirch
2004-04-14 22:09 ` Sridhar Samudrala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).