From: Sven Schuster <schuster.sven@gmx.de>
To: Matt Mackall <mpm@selenic.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@oss.sgi.com
Subject: Re: [patch] tg3 ring buffer allocation error handling
Date: Thu, 15 Apr 2004 00:02:54 +0200 [thread overview]
Message-ID: <20040414220254.GA24974@zion.homelinux.com> (raw)
In-Reply-To: <20040414214510.GH1175@waste.org>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On Wed, Apr 14, 2004 at 04:45:10PM -0500, Matt Mackall told us:
> > Please correct me if I'm wrong, but shouldn't the buffers from the
> > irst allocation (RXD_OPAQUE_RING_STD) be freed (maybe via
> > tg3_free_rings??) when we get an error here??
>
> The buffers are freed in the module release path, which is invoked
> when we return failure here. Without this, we don't notice the
> allocation failure and instead blow up when we get traffic.
So thanks for correcting me :-) should have taken a closer look at
the tg3 source.
Sven
>
> FYI, I last tested this on a mem=4M box, where it was very obvious
> that the 1M of ring buffers weren't leaking.
>
> --
> Matt Mackall : http://www.selenic.com : Linux development and consulting
--
Linux zion 2.6.5 #1 Sun Apr 4 19:56:55 CEST 2004 i686 athlon i386 GNU/Linux
00:01:49 up 10 days, 45 min, 2 users, load average: 0.06, 0.05, 0.02
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2004-04-14 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 18:46 [patch] tg3 ring buffer allocation error handling Matt Mackall
2004-04-14 20:59 ` Sven Schuster
2004-04-14 21:45 ` Matt Mackall
2004-04-14 22:02 ` Sven Schuster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040414220254.GA24974@zion.homelinux.com \
--to=schuster.sven@gmx.de \
--cc=jgarzik@pobox.com \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).