From: "Paul Rolland" <rol@as2917.net>
To: "'Stephen Hemminger'" <shemminger@osdl.org>,
"'David S. Miller'" <davem@redhat.com>
Cc: "'Paul Rolland'" <rol@witbe.net>, <linux-kernel@vger.kernel.org>,
<netdev@oss.sgi.com>
Subject: RE: [2.6.5] Bad scheduling while atomic
Date: Sun, 18 Apr 2004 20:50:55 +0200 [thread overview]
Message-ID: <200404181851.i3IIp1107295@tag.witbe.net> (raw)
In-Reply-To: <20040416131633.1bfbfa4c@dell_ss3.pdx.osdl.net>
Thanks Stephen for being so fast !
Regards,
Paul
Paul Rolland, rol(at)as2917.net
ex-AS2917 Network administrator and Peering Coordinator
--
Please no HTML, I'm not a browser - Pas d'HTML, je ne suis pas un navigateur
"Some people dream of success... while others wake up and work hard at it"
> -----Message d'origine-----
> De : linux-kernel-owner@vger.kernel.org
> [mailto:linux-kernel-owner@vger.kernel.org] De la part de
> Stephen Hemminger
> Envoyé : vendredi 16 avril 2004 22:17
> À : David S. Miller
> Cc : Paul Rolland; linux-kernel@vger.kernel.org; netdev@oss.sgi.com
> Objet : Re: [2.6.5] Bad scheduling while atomic
>
> Bring up/down network devices with lapbether causes scheduling while
> atomic (if preempt enabled).
>
> The calls to rcu_read_lock are unnecessary since lapb_device_event
> is called from notifier with the rtnetlink semaphore held, it is
> already protected from the labp_devices list changing.
>
> Patch against 2.6.6-rc1
>
> diff -Nru a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
> --- a/drivers/net/wan/lapbether.c Fri Apr 16 11:00:35 2004
> +++ b/drivers/net/wan/lapbether.c Fri Apr 16 11:00:35 2004
> @@ -392,6 +392,8 @@
>
> /*
> * Handle device status changes.
> + *
> + * Called from notifier with RTNL held.
> */
> static int lapbeth_device_event(struct notifier_block *this,
> unsigned long event, void *ptr)
> @@ -402,7 +404,6 @@
> if (!dev_is_ethdev(dev))
> return NOTIFY_DONE;
>
> - rcu_read_lock();
> switch (event) {
> case NETDEV_UP:
> /* New ethernet device -> new LAPB interface */
> @@ -422,7 +423,6 @@
> lapbeth_free_device(lapbeth);
> break;
> }
> - rcu_read_unlock();
>
> return NOTIFY_DONE;
> }
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
prev parent reply other threads:[~2004-04-18 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200404161551.i3GFpD124970@tag.witbe.net>
2004-04-16 20:16 ` [2.6.5] Bad scheduling while atomic Stephen Hemminger
2004-04-16 21:56 ` David S. Miller
2004-04-18 18:50 ` Paul Rolland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404181851.i3IIp1107295@tag.witbe.net \
--to=rol@as2917.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=rol@witbe.net \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).