netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix return value on MCAST_MSFILTER error case
@ 2004-04-21  1:05 Chris Wright
  2004-04-21 23:46 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Wright @ 2004-04-21  1:05 UTC (permalink / raw)
  To: davem; +Cc: netdev

Return -EINVAL if (GROUP_FILTER_SIZE(gsf->gf_numsrc) > optlen)

===== net/ipv4/ip_sockglue.c 1.22 vs edited =====
--- 1.22/net/ipv4/ip_sockglue.c	Mon Mar  8 12:15:03 2004
+++ edited/net/ipv4/ip_sockglue.c	Tue Apr 20 18:00:50 2004
@@ -800,7 +800,7 @@
 				goto mc_msf_out;
 			}
 			if (GROUP_FILTER_SIZE(gsf->gf_numsrc) > optlen) {
-				err = EINVAL;
+				err = -EINVAL;
 				goto mc_msf_out;
 			}
 			msize = IP_MSFILTER_SIZE(gsf->gf_numsrc);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix return value on MCAST_MSFILTER error case
  2004-04-21  1:05 [PATCH] fix return value on MCAST_MSFILTER error case Chris Wright
@ 2004-04-21 23:46 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-04-21 23:46 UTC (permalink / raw)
  To: Chris Wright; +Cc: netdev

On Tue, 20 Apr 2004 18:05:51 -0700
Chris Wright <chrisw@osdl.org> wrote:

> Return -EINVAL if (GROUP_FILTER_SIZE(gsf->gf_numsrc) > optlen)

Good catch, applied.

Thanks Chris.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-21 23:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-21  1:05 [PATCH] fix return value on MCAST_MSFILTER error case Chris Wright
2004-04-21 23:46 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).