netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pktgen dependency (was: Re: Linux 2.4.27-pre1)
       [not found] <20040422130651.GB18358@logos.cnet>
@ 2004-04-23 14:58 ` Geert Uytterhoeven
  2004-04-23 23:39   ` David S. Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2004-04-23 14:58 UTC (permalink / raw)
  To: Marcelo Tosatti, netdev; +Cc: Linux Kernel Development, linux-net


The packet generator doesn't compile if procfs is disabled.
IIRC, there was an agreement that this dependency is needed:

--- linux-2.4.27-pre1/net/Config.in.orig	2003-10-01 20:49:26.000000000 +0200
+++ linux-2.4.27-pre1/net/Config.in	2004-04-23 14:43:58.000000000 +0200
@@ -99,7 +99,7 @@

 mainmenu_option next_comment
 comment 'Network testing'
-tristate 'Packet Generator (USE WITH CAUTION)' CONFIG_NET_PKTGEN
+dep_tristate 'Packet Generator (USE WITH CAUTION)' CONFIG_NET_PKTGEN $CONFIG_PROC_FS
 endmenu

 endmenu

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pktgen dependency (was: Re: Linux 2.4.27-pre1)
  2004-04-23 14:58 ` [PATCH] pktgen dependency (was: Re: Linux 2.4.27-pre1) Geert Uytterhoeven
@ 2004-04-23 23:39   ` David S. Miller
  2004-04-25 10:19     ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2004-04-23 23:39 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: marcelo.tosatti, netdev, linux-kernel, linux-net

On Fri, 23 Apr 2004 16:58:58 +0200 (MEST)
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> The packet generator doesn't compile if procfs is disabled.
> IIRC, there was an agreement that this dependency is needed:

Applied, thanks Geert.  Can you cook up a 2.6.x variant as well
if that is needed too?

Thanks again.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pktgen dependency (was: Re: Linux 2.4.27-pre1)
  2004-04-23 23:39   ` David S. Miller
@ 2004-04-25 10:19     ` Geert Uytterhoeven
  0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2004-04-25 10:19 UTC (permalink / raw)
  To: David S. Miller
  Cc: Marcelo Tosatti, netdev, Linux Kernel Development, linux-net

On Fri, 23 Apr 2004, David S. Miller wrote:
> On Fri, 23 Apr 2004 16:58:58 +0200 (MEST)
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> > The packet generator doesn't compile if procfs is disabled.
> > IIRC, there was an agreement that this dependency is needed:
>
> Applied, thanks Geert.  Can you cook up a 2.6.x variant as well
> if that is needed too?

2.6.6-rc2 already has

    config NET_PKTGEN
	    tristate "Packet Generator (USE WITH CAUTION)"
	    depends on PROC_FS

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-04-25 10:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20040422130651.GB18358@logos.cnet>
2004-04-23 14:58 ` [PATCH] pktgen dependency (was: Re: Linux 2.4.27-pre1) Geert Uytterhoeven
2004-04-23 23:39   ` David S. Miller
2004-04-25 10:19     ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).