From: Pavel Machek <pavel@suse.cz>
To: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Netdev <netdev@oss.sgi.com>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] tulip driver deadlocks on device removal
Date: Tue, 4 May 2004 16:11:28 +0200 [thread overview]
Message-ID: <20040504141127.GH1188@openzaurus.ucw.cz> (raw)
In-Reply-To: <4096BBC8.60509@gmx.net>
Hi!
> If I remove the card, my machine freezes instantly. This is due to a
> stupid dev->poll function of the tulip driver.
>
> drivers/net/tulip/interrupt.c:tulip_poll() gets stuck in an endless loop
> in interrupt context if the hardware returns 0xffffffff on certain reads.
> But this is exactly what happens if you remove a pci device.
>
> My patch replaces the deadlock with something resembling a livelock. At
> least SysRq-S works now because we leave the poll function after some time.
Could you explicitely check for read returning 0xffffffff?
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
prev parent reply other threads:[~2004-05-04 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-03 21:38 [PATCH] tulip driver deadlocks on device removal Carl-Daniel Hailfinger
2004-05-04 14:11 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040504141127.GH1188@openzaurus.ucw.cz \
--to=pavel@suse.cz \
--cc=c-d.hailfinger.kernel.2004@gmx.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).