From: "David S. Miller" <davem@redhat.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: netdev@oss.sgi.com, netdev-bounce@oss.sgi.com
Subject: Re: [PATCH] bug in ARP override timer near jiffies wrap
Date: Fri, 7 May 2004 14:55:01 -0700 [thread overview]
Message-ID: <20040507145501.24fdd83a.davem@redhat.com> (raw)
In-Reply-To: <OFCBE52D62.180AE438-ON88256E8D.0077E81B-88256E8D.00780545@us.ibm.com>
On Fri, 7 May 2004 14:51:13 -0700
David Stevens <dlstevens@us.ibm.com> wrote:
> David S. Miller wrote on 05/07/2004 02:40:00 PM:
>
> > David, do you realize that the existing formula is not only
> > correct, but also covers a greater time space than the
> > time_*() mechanisms do?
>
> ARG! you're right, of course-- I noticed only that they are
> different and didn't think about it actually be right! :-)
But note that the main point is also that your change is
still correct.
The only reason I know about the time space issue with these
tests is that Alexey mentioned it to me when I was converting
most of the TCP code over to use the time_*() macros.
It is a policy decision whether it is more valuable to be
more consistent or support the larger time space in tests
here and there.
I think it is more important to be consistent, so I'm going
to apply your patch. And for ARP the larger time space would
never matter anyways :-)
prev parent reply other threads:[~2004-05-07 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 20:01 [PATCH] bug in ARP override timer near jiffies wrap David Stevens
2004-05-07 21:40 ` David S. Miller
2004-05-07 21:51 ` David Stevens
2004-05-07 21:55 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040507145501.24fdd83a.davem@redhat.com \
--to=davem@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=netdev-bounce@oss.sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).