From: Christoph Hellwig <hch@infradead.org>
To: James Morris <jmorris@redhat.com>
Cc: "David S. Miller" <davem@redhat.com>,
Stephen Smalley <sds@epoch.ncsc.mil>,
Chris Wright <chrisw@osdl.org>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
selinux@tycho.nsa.gov
Subject: Re: [PATCH][SELINUX] 2/2 sock_create_lite()
Date: Fri, 7 May 2004 16:14:56 +0100 [thread overview]
Message-ID: <20040507161455.A31114@infradead.org> (raw)
In-Reply-To: <Xine.LNX.4.44.0405071056300.21372-100000@thoron.boston.redhat.com>; from jmorris@redhat.com on Fri, May 07, 2004 at 11:06:04AM -0400
On Fri, May 07, 2004 at 11:06:04AM -0400, James Morris wrote:
> This patch adds a function sock_create_lite(), deprecating kernel-wide use
> of sock_alloc(), which has been made static to net/socket.c.
We're in the stable series and removing exported APIs there shoudn't happen.
Given that sock_alloc() is actually okay for every normal use I don't think
there's enough reason to remove it from the API.
> +int sock_create_lite(int family, int type, int protocol, struct socket **res)
Should probably be called __sock_create according to linux naming rules.
Also I guess you should actually call it from sock_create instead of
duplicating the code.
next prev parent reply other threads:[~2004-05-07 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Xine.LNX.4.44.0405071043540.21372@thoron.boston.redhat.com>
2004-05-07 15:06 ` [PATCH][SELINUX] 2/2 sock_create_lite() James Morris
2004-05-07 15:14 ` Christoph Hellwig [this message]
2004-05-07 15:21 ` James Morris
2004-05-07 19:53 ` James Morris
2004-05-08 22:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040507161455.A31114@infradead.org \
--to=hch@infradead.org \
--cc=chrisw@osdl.org \
--cc=davem@redhat.com \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=sds@epoch.ncsc.mil \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).