netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] IPV4: dead lock in error path
@ 2004-05-21  8:23 YOSHIFUJI Hideaki / 吉藤英明
  2004-05-21 21:40 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-05-21  8:23 UTC (permalink / raw)
  To: davem; +Cc: netdev, yoshfuji

Hello.

We forgot to release ipip_lock in error path.

--yoshfuji

===== net/ipv4/ipip.c 1.40 vs edited =====
--- 1.40/net/ipv4/ipip.c	Mon Feb 23 14:45:28 2004
+++ edited/net/ipv4/ipip.c	Fri May 21 17:17:28 2004
@@ -479,6 +479,7 @@
 	read_lock(&ipip_lock);
 	if ((tunnel = ipip_tunnel_lookup(iph->saddr, iph->daddr)) != NULL) {
 		if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb)) {
+			read_unlock(&ipip_lock);
 			kfree_skb(skb);
 			return 0;
 		}

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-21 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-21  8:23 [PATCH] IPV4: dead lock in error path YOSHIFUJI Hideaki / 吉藤英明
2004-05-21 21:40 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).