netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Arthur Kepner <akepner@sgi.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] "lockless loopback" patch for 2.6.6
Date: Fri, 21 May 2004 14:45:57 -0700	[thread overview]
Message-ID: <20040521144557.6a2c6a02.davem@redhat.com> (raw)
In-Reply-To: <Pine.SGI.4.56.0405211356440.8333289@neteng.engr.sgi.com>

On Fri, 21 May 2004 14:04:09 -0700
Arthur Kepner <akepner@sgi.com> wrote:

> Lock contention on the loopback device can lead to poor
> performance, even an essentially hung system, on systems
> with many processors.
> 
> For the loopback device, the only purpose that locking serves
> is to protect the device statistics. The attached patch
> keeps per-cpu statistics for the loopback device and removes
> all locking. The patch is against 2.6.6.

It is legal to attach queueing disciplines to the loopback device
but your patch makes that impossible.

I don't think it is worth worrying about things like this especially
if you're going to be adding ugly loopback special cases to the
generic device handling code like this.

  parent reply	other threads:[~2004-05-21 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-11 19:57 [PATCH] fix "ethtool -S" for tg3 Arthur Kepner
2004-05-12 19:08 ` David S. Miller
2004-05-12 20:00   ` Arthur Kepner
2004-05-20  4:26     ` David S. Miller
2004-05-21 21:04     ` [PATCH] "lockless loopback" patch for 2.6.6 Arthur Kepner
2004-05-21 21:45       ` Stephen Hemminger
2004-05-21 21:45       ` David S. Miller [this message]
2004-05-22 12:20       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040521144557.6a2c6a02.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akepner@sgi.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).