From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com, linux-net@vger.kernel.org
Subject: Re: IPSec Oops when deleting an ip address
Date: Mon, 24 May 2004 10:14:49 -0700 [thread overview]
Message-ID: <20040524101449.053e74f9.davem@redhat.com> (raw)
In-Reply-To: <20040524114751.GA28571@gondor.apana.org.au>
On Mon, 24 May 2004 21:47:51 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Hence the problem is still a bug in the ref counting. I think I've found
> the real culprit now. __xfrm?_find_acq() is missing an xfrm_state_hold
> on the create path. This also explains why I never see it myself since
> Openswan never creates states through that code-path.
Applied, thanks Herbert.
How the heck are you generating your patches? Because the file paths
look like this in the patch:
--- 1.6/net/ipv4/xfrm4_state.c 2003-07-21 21:49:43 +10:00
+++ edited/xfrm4_state.c 2004-05-24 21:41:29 +10:00
My auto-patch-application scripts explode since the path
depth of the file is different in the second line there.
How come it doesn't look like:
--- 1.6/net/ipv4/xfrm4_state.c 2003-07-21 21:49:43 +10:00
+++ edited/net/ipv4/xfrm4_state.c 2004-05-24 21:41:29 +10:00
So that I can throw "-p1" to tools like diffstat and get sane
output?
Your patches never did this in the past :-)
next prev parent reply other threads:[~2004-05-24 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040510134958.13691.qmail@mason.oriente.labs.it>
2004-05-21 13:19 ` IPSec Oops when deleting an ip address Herbert Xu
2004-05-21 21:43 ` David S. Miller
2004-05-24 11:47 ` Herbert Xu
2004-05-24 17:14 ` David S. Miller [this message]
2004-05-25 11:52 ` Herbert Xu
2004-05-25 18:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040524101449.053e74f9.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).