netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: hadi@cyberus.ca
Cc: Jaume Catarineu <jaume.catarineu@upf.edu>,
	"David S. Miller" <davem@redhat.com>,
	netdev@oss.sgi.com
Subject: Re: Kernel BUG: Qos seg. fault
Date: Tue, 25 May 2004 02:07:57 -0500	[thread overview]
Message-ID: <200405250207.58376.dtor_core@ameritech.net> (raw)
In-Reply-To: <1085436571.1041.69.camel@jzny.localdomain>

On Monday 24 May 2004 05:09 pm, jamal wrote:
> On Mon, 2004-05-24 at 17:53, Dmitry Torokhov wrote:
> 
> 
> > It just does... 
> 
> you mean just "because" ? ;-> Semantics allow you to do more.
> 
> > TBF as far as I understand is a simple rate
> > limiting tool for your network link. 
> 
> Consider it a scheduler really.
> 
> > I implemented the child
> > qdisc for TBF so you can change default fifo queue in it to
> > SFQ or PRIO. It supposed to be very lightweight. If you need
> > something more complex/fancy then you probably want HTB or CBF.
> 
> Ok, I thought you were trying to hierachical token buckets. Why coulnt
> you go the extra step?
> In any case, i agree what you have is a lightweight improvement; but you
> could go the next mile.
> Your original patch should be sufficient in the case you just want to
> stay there.
> 

Yes, I think we should stay right here. If we go that next mile we will
get HTB and we already have a decent implementation ;)

-- 
Dmitry

  parent reply	other threads:[~2004-05-25  7:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-24 21:53 Kernel BUG: Qos seg. fault Dmitry Torokhov
2004-05-24 22:09 ` jamal
2004-05-25  2:06   ` Jaume Catarineu
2004-05-25  3:29   ` Kernel BUG: Qos seg. fault (part II) Jaume Catarineu
2004-05-25  2:08     ` jamal
2004-05-25 13:09       ` Jaume Catarineu
2004-05-25  7:07   ` Dmitry Torokhov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-05-24 21:25 Kernel BUG: Qos seg. fault Dmitry Torokhov
2004-05-24 21:32 ` jamal
2004-05-24 21:42   ` jamal
2004-05-24 20:14 Dmitry Torokhov
2004-05-24 19:29 Dmitry Torokhov
2004-05-24 19:47 ` jamal
2004-05-24 11:57 Jaume Catarineu
2004-05-24 18:11 ` jamal
2004-05-24 19:19 ` Francois Romieu
2004-05-25  0:49   ` Jaume Catarineu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405250207.58376.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=davem@redhat.com \
    --cc=hadi@cyberus.ca \
    --cc=jaume.catarineu@upf.edu \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).