* Patch: b44.c: Always restore pci config on resume
@ 2004-05-26 21:17 Stefan Rompf
0 siblings, 0 replies; only message in thread
From: Stefan Rompf @ 2004-05-26 21:17 UTC (permalink / raw)
To: netdev, davem
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
Hi,
the Broadcom BCM4401 driver restores pci configuration on resume only when the
device is up. On my notebook, this leads to a failure when the device is down
during the S3 cycle. Short solution for now: Always restore pci config. Patch
against 2.6.7rc1 attached, please apply.
Stefan
[-- Attachment #2: b44-resume.diff --]
[-- Type: text/x-diff, Size: 488 bytes --]
--- linux-2.6.7rc1-orig/drivers/net/b44.c 2004-05-26 23:00:59.474435392 +0200
+++ linux-2.6.7rc1/drivers/net/b44.c 2004-05-26 22:22:12.000000000 +0200
@@ -1882,11 +1882,11 @@ static int b44_resume(struct pci_dev *pd
struct net_device *dev = pci_get_drvdata(pdev);
struct b44 *bp = dev->priv;
+ pci_restore_state(pdev, bp->pci_cfg_state);
+
if (!netif_running(dev))
return 0;
- pci_restore_state(pdev, bp->pci_cfg_state);
-
spin_lock_irq(&bp->lock);
b44_init_rings(bp);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-05-26 21:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-26 21:17 Patch: b44.c: Always restore pci config on resume Stefan Rompf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).