From: Greg Banks <gnb@sgi.com>
To: Michael Chan <mchan@broadcom.com>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH] fix BUG in tg3_tx
Date: Thu, 27 May 2004 09:50:08 +1000 [thread overview]
Message-ID: <20040526235008.GB5958@sgi.com> (raw)
In-Reply-To: <B1508D50A0692F42B217C22C02D849727FEDBE@NT-IRVA-0741.brcm.ad.broadcom.com>
On Wed, May 26, 2004 at 10:43:10AM -0700, Michael Chan wrote:
>
> > [...] is there a good reason why the tg3 driver
> > uses the on-chip SRAM send ring by default instead of the
> > host send ring?[...]
>
> I can only speak for the Broadcom bcm5700 driver. We used to use NIC
> send BDs by default before zero copy transmit and TSO were implemented
> in the kernel. Using only one BD per packet at that time, we found that
> performance on some machines were sometimes slightly better. Especially
> with logic to save some PIO when some of the fields in the BD have not
> changed. The driver has now been changed to use host send BDs to perform
> better with zero copy and especially TSO where you may need many BDs per
> packet. I would recommend tg3 to make the switch also.
Ah, it's precisely the zero copy case I'm interested in. I've measured
2 to 3 BDs per packet under my load.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
next prev parent reply other threads:[~2004-05-26 23:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-26 17:43 [PATCH] fix BUG in tg3_tx Michael Chan
2004-05-26 18:47 ` David S. Miller
2004-05-26 23:52 ` Greg Banks
2004-05-26 23:50 ` Greg Banks [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-05-26 1:22 Michael Chan
2004-05-25 20:04 Michael Chan
2004-05-26 0:54 ` Greg Banks
2004-05-26 16:04 ` Greg Banks
2004-05-26 18:01 ` David S. Miller
2004-05-26 23:47 ` Greg Banks
2004-05-26 23:52 ` David S. Miller
2004-05-27 0:12 ` Greg Banks
2004-05-24 17:33 Michael Chan
2004-05-24 17:26 Michael Chan
2004-05-24 7:26 Greg Banks
2004-05-24 7:40 ` David S. Miller
2004-05-24 8:04 ` Greg Banks
2004-05-24 17:06 ` David S. Miller
2004-05-25 1:04 ` Greg Banks
2004-05-25 17:51 ` David S. Miller
2004-05-26 0:12 ` Greg Banks
2004-05-25 17:52 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040526235008.GB5958@sgi.com \
--to=gnb@sgi.com \
--cc=davem@redhat.com \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).