From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugene Surovegin Subject: Re: [IPSEC] fix ref counting in __xfrm4_bundle_create() Date: Fri, 28 May 2004 21:21:20 -0700 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040529042120.GA3623@gate.ebshome.net> References: <20040529001450.GA647@gate.ebshome.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@oss.sgi.com, davem@redhat.com Return-path: To: Herbert Xu Content-Disposition: inline In-Reply-To: Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Sat, May 29, 2004 at 01:27:13PM +1000, Herbert Xu wrote: > However, can you see if the following patch fixes this problem as well? > It moves the dst->xfrm assignment to a spot where errors cannot occur. Yeah, looks much nicer than my version. I'll try to test it tomorrow if I find somebody from QA in the office on Saturday :) or only after a long weekend (test setup is quite complicated and I cannot reproduce it at home). Eugene.