netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]: Fix NULL-ptr dereference in irlmp_get_saddr()
@ 2004-05-28 10:56 Patrick McHardy
  2004-05-28 16:41 ` Jean Tourrilhes
  2004-05-29 19:40 ` David S. Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Patrick McHardy @ 2004-05-28 10:56 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, jt

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

This patch fixes a NULL-ptr dereference in irlmp_get_saddr.

Regards
Patrick

[-- Attachment #2: irlmp_get_saddr-NULL-ptr.diff --]
[-- Type: text/x-patch, Size: 764 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/05/28 12:32:37+02:00 kaber@trash.net 
#   [IRDA]: Fix NULL-ptr dereference in irlmp_get_saddr()
# 
# include/net/irda/irlmp.h
#   2004/05/28 12:32:30+02:00 kaber@trash.net +1 -1
#   [IRDA]: Fix NULL-ptr dereference in irlmp_get_saddr()
# 
diff -Nru a/include/net/irda/irlmp.h b/include/net/irda/irlmp.h
--- a/include/net/irda/irlmp.h	2004-05-28 12:35:56 +02:00
+++ b/include/net/irda/irlmp.h	2004-05-28 12:35:56 +02:00
@@ -251,7 +251,7 @@
 
 static inline __u32 irlmp_get_saddr(const struct lsap_cb *self)
 {
-	return (self && !self->lap) ? self->lap->saddr : 0;
+	return (self && self->lap) ? self->lap->saddr : 0;
 }
 
 static inline __u32 irlmp_get_daddr(const struct lsap_cb *self)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH]: Fix NULL-ptr dereference in irlmp_get_saddr()
  2004-05-28 10:56 [PATCH]: Fix NULL-ptr dereference in irlmp_get_saddr() Patrick McHardy
@ 2004-05-28 16:41 ` Jean Tourrilhes
  2004-05-29 19:40 ` David S. Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Jean Tourrilhes @ 2004-05-28 16:41 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: David S. Miller, netdev

On Fri, May 28, 2004 at 12:56:50PM +0200, Patrick McHardy wrote:
> This patch fixes a NULL-ptr dereference in irlmp_get_saddr.
> 
> Regards
> Patrick

	Wow ! This one is scary !
	Thanks

	Jean

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH]: Fix NULL-ptr dereference in irlmp_get_saddr()
  2004-05-28 10:56 [PATCH]: Fix NULL-ptr dereference in irlmp_get_saddr() Patrick McHardy
  2004-05-28 16:41 ` Jean Tourrilhes
@ 2004-05-29 19:40 ` David S. Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2004-05-29 19:40 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: netdev, jt

On Fri, 28 May 2004 12:56:50 +0200
Patrick McHardy <kaber@trash.net> wrote:

> This patch fixes a NULL-ptr dereference in irlmp_get_saddr.

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-05-29 19:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-28 10:56 [PATCH]: Fix NULL-ptr dereference in irlmp_get_saddr() Patrick McHardy
2004-05-28 16:41 ` Jean Tourrilhes
2004-05-29 19:40 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).