From: Adrian Bunk <bunk@fs.tum.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, "Randy.Dunlap" <rddunlap@osdl.org>,
Danny ter Haar <dth@dth.net>,
wa1ter@myrealbox.com, dth@ncc1701.cistron.net,
Netdev <netdev@oss.sgi.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] Re: Gigabit Kconfig problems with yesterday's update
Date: Sun, 30 May 2004 21:37:06 +0200 [thread overview]
Message-ID: <20040530193706.GG13111@fs.tum.de> (raw)
In-Reply-To: <40BA1F25.4080402@pobox.com>
On Sun, May 30, 2004 at 01:51:33PM -0400, Jeff Garzik wrote:
> NET_GIGE is rightly dependent on NET_ETHERNET, as it is a subset.
>
> I wonder if the attached patch "fixes" peoples config problems :)
>
> ===== drivers/net/Kconfig 1.74 vs edited =====
> --- 1.74/drivers/net/Kconfig 2004-05-27 16:42:40 -04:00
> +++ edited/drivers/net/Kconfig 2004-05-30 13:49:48 -04:00
> @@ -163,7 +163,7 @@
> depends on NETDEVICES
>
> config NET_ETHERNET
> - bool "Ethernet (10 or 100Mbit)"
> + bool "Ethernet (10/100/1000/10000 Mbit)"
> ---help---
> Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common
> type of Local Area Network (LAN) in universities and companies.
This is not sufficient since it's still under the
"Ethernet (10 or 100Mbit)" menu.
What about the patch below?
cu
Adrian
--- linux-2.6.7-rc2-full/drivers/net/Kconfig.old 2004-05-30 21:29:46.000000000 +0200
+++ linux-2.6.7-rc2-full/drivers/net/Kconfig 2004-05-30 21:34:42.000000000 +0200
@@ -159,11 +159,8 @@
# Ethernet
#
-menu "Ethernet (10 or 100Mbit)"
- depends on NETDEVICES
-
config NET_ETHERNET
- bool "Ethernet (10 or 100Mbit)"
+ bool "Ethernet (10/100/1000/10000 Mbit)"
---help---
Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common
type of Local Area Network (LAN) in universities and companies.
@@ -188,6 +185,9 @@
kernel: saying N will just cause the configurator to skip all
the questions about Ethernet network cards. If unsure, say N.
+menu "Ethernet (10/100 Mbit)"
+ depends on NET_ETHERNET
+
config MII
tristate "Generic Media Independent Interface device support"
depends on NET_ETHERNET
@@ -1875,7 +1875,7 @@
#
menu "Gigabit Ethernet (1000/10000 Mbit)"
- depends on NETDEVICES
+ depends on NET_ETHERNET
config NET_GIGE
bool "Gigabit Ethernet (1000/10000 Mbit) controller support"
next prev parent reply other threads:[~2004-05-30 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <40B8A37D.1090802@myrealbox.com>
[not found] ` <20040530134544.GE13111@fs.tum.de>
[not found] ` <20040530143734.GA24627@dth.net>
[not found] ` <20040530094120.61b22d2e.rddunlap@osdl.org>
2004-05-30 17:51 ` [patch] Re: Gigabit Kconfig problems with yesterday's update Jeff Garzik
2004-05-30 19:37 ` Adrian Bunk [this message]
2004-05-30 20:06 ` Linus Torvalds
2004-05-30 20:43 ` Jeff Garzik
2004-05-31 7:32 ` Christoph Hellwig
2004-05-31 10:00 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040530193706.GG13111@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=dth@dth.net \
--cc=dth@ncc1701.cistron.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=rddunlap@osdl.org \
--cc=wa1ter@myrealbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).